Allow %title% in params, for the current page title

RESOLVED WONTFIX

Status

()

P3
enhancement
RESOLVED WONTFIX
17 years ago
14 years ago

People

(Reporter: thomas.thurman, Assigned: Wurblzap)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
Bugzilla parameters should be able to refer to the HTML title of the current 
page, so that the bannerhtml parameter can use %title% as part of a headline.

This can be done in 2.14.1 by changing the line in the PutHeader function in 
CGI.pl from:
    print PerformSubsts(Param("bannerhtml"), undef);
to:
    print PerformSubsts(Param("bannerhtml"), {title => $title});

As an example, the bannerhtml for the site given in the URL is

<table cellpadding="0" cellspacing="0" width="100%" height="101"><tr 
height="24"><td 
bgcolor="#FFFFFF" rowspan="3" width="101"><a href="."><img 
src="camcockroach.gif" alt="" height="104" width="101" 
align="middle" alt="&gt;:##" border="0"></a></td><td 
bgcolor="#FFFFFF">&nbsp;</td></tr><tr height="58"><td bgcolor="#FF0000" 
align="center"><font face="LinotypeBrewery Medium" size="5" 
color="#FFFFFF">%title%</font></td></tr><tr height="22"><td 
bgcolor="#FFFFFF">&nbsp;</td></tr></table>
(Reporter)

Updated

17 years ago
Summary: Add a param "title" → Allow %title% in params, for the current page title
Move to 2.18, but I doubt this can be done automatically in the TT world.  It's
probably OK as is given the way the global/header template works.
Priority: -- → P3
Target Milestone: --- → Bugzilla 2.18
Actually we could probably make sure title is passed into the banner template.
Enhancements which don't currently have patches on them which are targetted at
2.18 are being retargetted to 2.20 because we're about to freeze for 2.18. 
Consideration will be taken for moving items back to 2.18 on a case-by-case
basis (but is unlikely for enhancements)
Target Milestone: Bugzilla 2.18 → Bugzilla 2.20
Bugzilla 2.20 feature set is now frozen as of 15 Sept 2004.  Anything flagged
enhancement that hasn't already landed is being pushed out.  If this bug is
otherwise ready to land, we'll handle it on a case-by-case basis, please set the
blocking2.20 flag to '?' if you think it qualifies.
Target Milestone: Bugzilla 2.20 → Bugzilla 2.22
Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.
Assignee: justdave → general
QA Contact: mattyt-bugzilla → default-qa
(Assignee)

Comment 6

14 years ago
Created attachment 178478 [details] [diff] [review]
Patch

The way of comment 2.

Maybe the bug needs to be morphed a little.
Assignee: general → wurblzap
Status: NEW → ASSIGNED
(Assignee)

Updated

14 years ago
Attachment #178478 - Flags: review?
(Assignee)

Updated

14 years ago
Target Milestone: Bugzilla 2.22 → Bugzilla 2.20

Comment 7

14 years ago
If you customize banner.html.tmpl, you are also able to customize
header.html.tmpl using Marc's patch. In the official releases of Bugzilla,
'title' is not used by banner.html.tmpl and I don't see the interest in adding
superfluous parameters. Be sure they would be removed by some developer who
would think "hey, I found obsolete parameters here; let's remove them!".

So marking this bug WONTFIX following my discussion with Marc in IRC.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WONTFIX
Target Milestone: Bugzilla 2.20 → ---
(Assignee)

Updated

14 years ago
Attachment #178478 - Flags: review?
You need to log in before you can comment on or make changes to this bug.