Handle empty changeset list from json-pushes

RESOLVED FIXED

Status

Tree Management
Treeherder: Data Ingestion
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: camd, Assigned: camd)

Tracking

(Blocks: 2 bugs)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
gps has pushed a change where json-pushes could return empty list of changesets for some repos.  If a push has an empty chagngeset, Treeherder's current ETL code will except out on the whole list of pushes.  We should fix this so it just skips that one push.

Updated

2 years ago
Blocks: 1286022
Depends on: 1286426
(Assignee)

Updated

2 years ago
Assignee: nobody → cdawson
Created attachment 8773841 [details] [review]
[treeherder] mozilla:empty-changesets > mozilla:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8773841 [details] [review]
[treeherder] mozilla:empty-changesets > mozilla:master

this is a pretty easy one.  :)
Attachment #8773841 - Flags: review?(emorley)

Comment 3

2 years ago
Comment on attachment 8773841 [details] [review]
[treeherder] mozilla:empty-changesets > mozilla:master

r+ with the tweak :-)
Attachment #8773841 - Flags: review?(emorley) → review+

Comment 4

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ff6a66a27c2c234e5820b8ffe48f17d85f1eb2db
Bug 1288181 - Handle empty changeset list from json-pushes (#1717)

If a pushlog contains hidden changesets (changesets that are
obsolete) then the call to json-pushes will return a push
with no changesets.  This was changed in bug 1286426.
For us, if `changesets` is empty, we will not be able to get
a revision, which is required for a resultset.  So we
need to just skip the push.
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Updated

2 years ago
Blocks: 1288845

Updated

a year ago
Blocks: 1365318
You need to log in before you can comment on or make changes to this bug.