1288209 - Don't use different blackbox icon in Debugger with Firebug theme

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect, P3)

Description

[magicp]

Attachment: Fix different blackbox icons in firebug theme.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160720030208

Steps to reproduce:

1. Start Nightly
2. Go to any sites (e.g. about:home)
3. Open DevTools > Debugger
4. Start black boxing for any sources


Actual results:

black-box button and black-boxed-message-button have each different blackbox icon in Firebug theme


Expected results:

Adopt chrome://devtools/skin/images/firebug/debugger-blackbox.svg

Comment 1

[Eddy Bruel [:ejpbruel]]

UI papercut, so marking this as P3. Helen, this seems like something you might want to look into?

Comment 2

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Eddy Bruel [:ejpbruel] from comment #1)
> UI papercut, so marking this as P3. Helen, this seems like something you
> might want to look into?

I actually think this is more a question for Honza—for Firebug do we want to use new styles as they're created, or do we want to continue using what was in Firebug previously? I flagged you on a box model bug that was similar recently, do you have a philosophy we can use as a general rule when bugs like this come up?

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?) from comment #2)
> (In reply to Eddy Bruel [:ejpbruel] from comment #1)
> > UI papercut, so marking this as P3. Helen, this seems like something you
> > might want to look into?
> 
> I actually think this is more a question for Honza—for Firebug do we want to
> use new styles as they're created, or do we want to continue using what was
> in Firebug previously? I flagged you on a box model bug that was similar
> recently, do you have a philosophy we can use as a general rule when bugs
> like this come up?
I think we need to individually solve case by case (at least for now),
but here are some comments:

1) Firebug theme is for Firebug 2 users to make the transition to DevTools simpler.
2) Firebug theme is built on top of Light theme so, we should always ask ourselves whether we can use the same icon/colors/etc. even for the Firebug theme (it's easier to maintain less differences).
3) If we are adopting a new icon (for Firebug theme) that didn't exist in Firebug 2 we should try to prefer the same as for the Light theme - if it fits the existing Firebug icon set well.
4) If an existing stuff is changing we should look at Firebug 2 and try to do it similarly (but not be afraid to innovate if needed)

Hope it helps

Btw. I agree with this bug report, it should be fixed.


@magicp: Thank you for the report and also for all the other reports you are doing,
you are doing great job!

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The Firebug theme was removed in Bug 1378108, so I am marking this report as WONTFIX.

Honza