1288213 - Intermittent devtools/client/inspector/layout/test/browser_layout_update-after-navigation.js | Test timed out -

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=32228208&repo=mozilla-inbound

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64/1469019440/mozilla-inbound_yosemite_r7_test-mochitest-devtools-chrome-1-bm132-tests1-macosx-build170.txt.gz

Comment 1

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 2

[Intermittent Failures Robot]

36 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 22
* autoland: 8
* fx-team: 6

Platform breakdown:
* windows8-64: 19
* osx-10-10: 12
* windowsxp: 2
* windows7-32-vm: 2
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-07-22&endday=2016-07-22&tree=all

Comment 3

[Intermittent Failures Robot]

50 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 27
* autoland: 13
* fx-team: 9
* try: 1

Platform breakdown:
* windows8-64: 22
* osx-10-10: 19
* windows7-32-vm: 3
* windowsxp: 2
* linux64: 2
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-07-18&endday=2016-07-24&tree=all

Comment 4

[Intermittent Failures Robot]

46 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 20
* autoland: 16
* fx-team: 9
* mozilla-central: 1

Platform breakdown:
* windows8-64: 32
* osx-10-10: 11
* windows7-32-vm: 2
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-07-25&endday=2016-07-25&tree=all

Comment 5

[Julian Descottes [:jdescottes]]

Very frequent intermittent now -> P1.

Comment 6

[Julian Descottes [:jdescottes]]

Could be linked to the same cause as Bug 1287745

Comment 7

[Intermittent Failures Robot]

55 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 27
* autoland: 15
* fx-team: 11
* try: 2

Platform breakdown:
* windows8-64: 36
* osx-10-10: 16
* windowsxp: 2
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-07-26&endday=2016-07-26&tree=all

Comment 8

[Intermittent Failures Robot]

37 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 17
* fx-team: 9
* autoland: 7
* mozilla-central: 3
* ash: 1

Platform breakdown:
* windows8-64: 22
* osx-10-10: 11
* windows7-32-vm: 3
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-07-27&endday=2016-07-27&tree=all

Comment 9

[Intermittent Failures Robot]

52 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 26
* fx-team: 13
* autoland: 12
* mozilla-central: 1

Platform breakdown:
* windows8-64: 30
* osx-10-10: 15
* windows7-32-vm: 5
* windowsxp: 1
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-07-28&endday=2016-07-28&tree=all

Comment 10

[Intermittent Failures Robot]

66 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 39
* autoland: 12
* fx-team: 10
* mozilla-central: 5

Platform breakdown:
* windows8-64: 47
* osx-10-10: 15
* windows7-32-vm: 3
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-07-29&endday=2016-07-29&tree=all

Comment 11

[Intermittent Failures Robot]

284 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 135
* autoland: 68
* fx-team: 61
* mozilla-central: 16
* try: 2
* ash: 2

Platform breakdown:
* windows8-64: 183
* osx-10-10: 76
* windows7-32-vm: 17
* windowsxp: 6
* windows7-32: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-07-25&endday=2016-07-31&tree=all

Comment 12

[Intermittent Failures Robot]

55 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 21
* autoland: 20
* fx-team: 7
* mozilla-central: 5
* mozilla-aurora: 2

Platform breakdown:
* windows8-64: 27
* osx-10-10: 20
* windows7-32-vm: 5
* windowsxp: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-08-01&endday=2016-08-01&tree=all

Comment 13

[Intermittent Failures Robot]

65 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 30
* autoland: 26
* fx-team: 6
* mozilla-aurora: 3

Platform breakdown:
* windows8-64: 31
* osx-10-10: 17
* windows7-32-vm: 10
* android-4-3-armv7-api15: 3
* windowsxp: 2
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-08-02&endday=2016-08-02&tree=all

Comment 14

[Intermittent Failures Robot]

65 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 31
* mozilla-inbound: 21
* fx-team: 9
* try: 2
* mozilla-central: 2

Platform breakdown:
* windows8-64: 30
* osx-10-10: 24
* windows7-32-vm: 7
* windowsxp: 2
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-08-03&endday=2016-08-03&tree=all

Comment 15

[Intermittent Failures Robot]

80 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 35
* mozilla-inbound: 27
* fx-team: 7
* mozilla-central: 6
* try: 3
* mozilla-aurora: 2

Platform breakdown:
* windows8-64: 42
* osx-10-10: 22
* windows7-32-vm: 9
* windowsxp: 6
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-08-04&endday=2016-08-04&tree=all

Comment 16

[Carsten Book [:Tomcat]]

can we fix this or disable this, this is number #3 on orangefactor

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/191f08f8ff31
disable browser_layout_update-after-navigation.js too many intermittent failures;r=me

Comment 18

[Julian Descottes [:jdescottes]]

(In reply to Carsten Book [:Tomcat] from comment #16)
> can we fix this or disable this, this is number #3 on orangefactor

Disabled by https://hg.mozilla.org/integration/fx-team/rev/191f08f8ff31 (since the test from Bug 1287745 was disabled, no reason to keep this one enabled, almost certain they share the same root cause).

Comment 19

[Intermittent Failures Robot]

49 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 22
* mozilla-inbound: 16
* fx-team: 9
* mozilla-central: 1
* mozilla-aurora: 1

Platform breakdown:
* windows8-64: 21
* osx-10-10: 15
* windowsxp: 6
* windows7-32-vm: 5
* linux64: 1
* android-4-3-armv7-api15: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-08-05&endday=2016-08-05&tree=all

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/191f08f8ff31

Comment 21

[Intermittent Failures Robot]

401 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 148
* mozilla-inbound: 146
* fx-team: 48
* mozilla-central: 41
* mozilla-aurora: 10
* try: 7
* ash: 1

Platform breakdown:
* windows8-64: 187
* osx-10-10: 115
* windows7-32-vm: 53
* windowsxp: 33
* linux64: 7
* android-4-3-armv7-api15: 4
* windows7-32: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-08-01&endday=2016-08-07&tree=all

Comment 22

[Sami Jaktholm]

Attachment: Bug 1288213 - Fix and re-enable intermittent layout view tests.

The reason for the intermittent timeouts wasn't actually in the layoutview but
in the computed view instead. It turns out computed view didn't handle
selection change during an ongoing update from previous selection change
correctly. When layout view was moved to the computed view, it caused more
things to happen during selection change which slowed the computed view
updates triggering this race condition.

Whenever selection changed, the previous update was canceled but the
promise that was blocking the inspector-updated event from being emitted
was never resolved nor rejected. This together with the fact that the
layoutview tests didn't properly wait for the initial update after
navigation / reload to finish before they triggered a new upload lead
to the inspector update to hang waiting for the inspector-updated event
and the test to timeout.

These changes fix the issues by rejecting the computed-view updated promise
whenever the update is canceled. This unblocks the inspector-updated event
to be emitted once the selection change has finished and stops the tests
from timing out.

Review commit: https://reviewboard.mozilla.org/r/70952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70952/

Comment 23

[Sami Jaktholm]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=638b3673ec6b

Comment 25

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8780215 [details]
Bug 1288213 - Fix and re-enable intermittent layout view tests.

https://reviewboard.mozilla.org/r/70952/#review68428

Thanks for the patch Sami!

Comment 27

[Intermittent Failures Robot]

12 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 12

Platform breakdown:
* windows7-32-vm: 5
* windowsxp: 3
* osx-10-10: 2
* windows8-64: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-08-08&endday=2016-08-14&tree=all

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/9e8fb23fc565
Fix and re-enable intermittent layout view tests. r=gl

Comment 29

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9e8fb23fc565

Comment 30

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d5c53363e8e4

Comment 33

[Intermittent Failures Robot]

9 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 9

Platform breakdown:
* windows7-32-vm: 5
* windows8-64: 2
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1288213&startday=2016-08-15&endday=2016-08-21&tree=all