Closed Bug 128830 Opened 22 years ago Closed 14 years ago

Can't open tabs on this page (preventBubble breaks contentAreaClick)

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED EXPIRED

People

(Reporter: xyzzy, Assigned: jag+mozilla)

References

(
URL
)

Details

Attachments

(1 file)

Basic idea
875 bytes, patch
Details | Diff | Splinter Review 
This is weird, build 2002022603 on Win98:

1. Go to http://www.mozilla.org/projects/mathml/start.xml
2. Ctrl+click on any of the links in the page.

Expected results:  Open the link in a new tab.
Actual results:  Nothing happens.
I thought, <ctrl>+click should open a new window for the URL ?
But I can confirm the effect,  <ctrl>+click does not work on that URL (tested
with  dayly 2002030208 / win98). 
norton@w5ac.tamu.edu, can you turn off the pref that opens tabs instead of
windows for ctrl-click, and see if it does open a new window?
Nevermind, I guess that's what Rainer is saying.

-> xpapps, cc blake.
Component: Tabbed Browser → XP Apps
-> default owner
Assignee: jaggernaut → trudelle
I assume this is because it is an xml page?  Should work, but still pretty
obscure and harmless.  ->future
Target Milestone: --- → Future
*** Bug 131507 has been marked as a duplicate of this bug. ***
See bug 131507 comment #1 regarding preventBubble().  Boris created a minimal
testcase as attachment 74652 [details].
Reassigning to blake, ccing jag.  Resetting milestone and requesting re-triage,
since this is not an XML issue -- this is something any page can do at will to
disable our various "special click" behaviors.

The problem is that the page calls preventBubble() on all mouse click events in
the onclick handler of <body>, so they never bubble out to the <tabbrowser>.
Assignee: trudelle → blaker
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: Future → ---
Attached patch Basic idea — — Splinter Review 
We should be using capture, imo, not bubbling.	Attaching patch which does
that...

This needs a lot more work.  For example, if we are opening a new window/tab
due to modifiers on the click we may want to .stopPropagation() the event or
something like that...
Summary: Can't open tabs on this page → Can't open tabs on this page (preventBubble breaks contentAreaClick)
Blocks: 141405
Blocks: 151142
No longer blocks: 141405
That's probably not the attachment you meant (some dtd in mailnews)
Er... right...  The patch just changed from using an onload attribute to
attaching an EventListener with the capture arg set to true (the attaching was
done in the <tabbrowser> constructor).
resolve as invalid per bug 105280 or change summary?
Bah, pedantry.  The important part is the effect, not the cause (there are at
least two different ways to stop event propagation _without_ calling
preventBubble()).  And this particular page _is_ using preventBubble(), so
resummarizing would just confuse people.
Product: Core → Mozilla Application Suite
Assignee: bross2 → jag
QA Contact: bugzilla
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → EXPIRED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: