Convert TestStandardURL to gtest

RESOLVED FIXED in Firefox 50

Status

()

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: valentin.gosu, Assigned: valentin.gosu)

Tracking

unspecified
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
MozReview-Commit-ID: FscilBXGhI2
Attachment #8773123 - Flags: review?(mcmanus)
Is there a missing moz.build in netwerk/test/gtest?
Added the missing moz.build. Thanks for the heads up :)
Attachment #8773242 - Flags: review?(mcmanus)
Attachment #8773123 - Attachment is obsolete: true
Attachment #8773123 - Flags: review?(mcmanus)
Comment on attachment 8773242 [details] [diff] [review]
Convert TestStandardURL to gtest

Review of attachment 8773242 [details] [diff] [review]:
-----------------------------------------------------------------

please put a try run showing this passing in the bug before landing. thanks
Attachment #8773242 - Flags: review?(mcmanus) → review+
Comment on attachment 8773242 [details] [diff] [review]
Convert TestStandardURL to gtest

Review of attachment 8773242 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/test/gtest/moz.build
@@ +5,5 @@
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +UNIFIED_SOURCES += [
> +    'TestStandardURL.cpp',
> +    'TestURIMutator.cpp',

Maybe need to handle or delete |TestURIMutator.cpp| before push to try
https://hg.mozilla.org/mozilla-central/rev/e29d0a6a50f0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
there is a regression in this test:
https://treeherder.mozilla.org/perf.html#/alerts?id=7260

from this changeset:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=92a8b8ce2f728ea5cc4ea8e4d8b3e2c5fe76a9ed&tochange=321e5a4f37b543c73055159b9630621890fc8b4e


I am not sure what we want to do with the results.

:valentin - can you please comment on how we should handle the results (regressions/improvements) from this test?
Flags: needinfo?(valentin.gosu)
Actually, I have no idea why that changeset would cause this regression. It shouldn't happen. The tests are for implementations that mostly do string parsing.
Flags: needinfo?(valentin.gosu)
You need to log in before you can comment on or make changes to this bug.