Closed Bug 1288328 Opened 4 years ago Closed 4 years ago

Remove MacQuirks.h mention from nsSuiteApp and other parts (if necessary)

Categories

(SeaMonkey :: Build Config, defect)

x86_64
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.47

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1282980 removed MacQuirks.h.   We're busted because of that.
Attached patch proposed patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8773186 - Flags: review?(stefanh)
Comment on attachment 8773186 [details] [diff] [review]
proposed patch (v1)

We're still busted with this patch :-)

nsSuiteApp.cpp uses TriggerQuirks():

#ifdef XP_MACOSX
  TriggerQuirks();
#endif

And TriggerQuirks() is defined in MacQuirks.h.

But r=me if you also remove the mentioned ifdef block.
Attachment #8773186 - Flags: review?(stefanh) → review+
Removed the include and the TriggerQuirks() block.
Attachment #8773186 - Attachment is obsolete: true
Attachment #8773798 - Flags: review+
I just pushed this with a=bustage:
https://hg.mozilla.org/comm-central/rev/b70cc92f7129
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.47
You need to log in before you can comment on or make changes to this bug.