Closed
Bug 1288331
Opened 6 years ago
Closed 6 years ago
OggDemuxer should seek video and audio track independently from one another
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
Details
Attachments
(2 files)
It currently only provides an API to seek , with no distinction of track. This is similar to bug 1274445 which was for webm and had the same problem.
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67188/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67188/
Assignee | ||
Updated•6 years ago
|
Attachment #8774736 -
Flags: review?(brion)
Assignee | ||
Comment 2•6 years ago
|
||
Fast seek in the old OggReader is broken: the audio track isn't seeked to the video track in order to preserve A/V sync and we end up always performing an accurate seek which explain why this test succeeded before. The page index is only made of two entries, and so the first video frame returned after a seek, if within the first index will always have a time of 0. Review commit: https://reviewboard.mozilla.org/r/67196/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67196/
Attachment #8774746 -
Flags: review?(cpearce)
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8774736 [details] Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67188/diff/1-2/
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8774746 [details] Bug 1288331: [ogg] P2. Fix fast seek mochitest. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67196/diff/1-2/
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8774736 [details] Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67188/diff/2-3/
Attachment #8774736 -
Attachment description: Bug 1288331. [ogg] P1. Seek audio track and video track independently from one another. → Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another.
Attachment #8774746 -
Attachment description: Bug 1288331. [ogg] P2. Fix fast seek mochitest. → Bug 1288331: [ogg] P2. Fix fast seek mochitest.
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8774746 [details] Bug 1288331: [ogg] P2. Fix fast seek mochitest. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67196/diff/2-3/
Comment 7•6 years ago
|
||
Comment on attachment 8774736 [details] Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another. https://reviewboard.mozilla.org/r/67188/#review64562
Attachment #8774736 -
Flags: review?(brion) → review+
Comment 8•6 years ago
|
||
Comment on attachment 8774746 [details] Bug 1288331: [ogg] P2. Fix fast seek mochitest. https://reviewboard.mozilla.org/r/67196/#review64608
Attachment #8774746 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 9•6 years ago
|
||
Comment on attachment 8774736 [details] Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67188/diff/3-4/
Assignee | ||
Comment 10•6 years ago
|
||
Comment on attachment 8774746 [details] Bug 1288331: [ogg] P2. Fix fast seek mochitest. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67196/diff/3-4/
Assignee | ||
Comment 11•6 years ago
|
||
Comment on attachment 8774736 [details] Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67188/diff/4-5/
Assignee | ||
Comment 12•6 years ago
|
||
Comment on attachment 8774746 [details] Bug 1288331: [ogg] P2. Fix fast seek mochitest. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67196/diff/4-5/
Assignee | ||
Comment 13•6 years ago
|
||
Comment on attachment 8774736 [details] Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67188/diff/5-6/
Assignee | ||
Comment 14•6 years ago
|
||
Comment on attachment 8774746 [details] Bug 1288331: [ogg] P2. Fix fast seek mochitest. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67196/diff/5-6/
Comment 15•6 years ago
|
||
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c249b34465a9 [ogg] P1. Seek audio track and video track independently from one another. r=brion+1012 https://hg.mozilla.org/integration/autoland/rev/60d5223a8d88 [ogg] P2. Fix fast seek mochitest. r=cpearce
Comment 16•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c249b34465a9 https://hg.mozilla.org/mozilla-central/rev/60d5223a8d88
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•