Don't change the play state of MediaDecoder when entering/exiting dormant state
RESOLVED
FIXED
in Firefox 50
Status
()
People
(Reporter: jwwang, Assigned: jwwang)
Tracking
Firefox Tracking Flags
(firefox50 fixed)
Details
MozReview Requests
()
| Submitter | Diff | Changes | Open Issues | Last Updated |
|---|---|---|---|---|
| Loading... | ||||
| Error loading review requests: | ||||
Attachments
(2 attachments)
The current logic of MediaDecoder is able to handle entering/exiting dormant state without changing its play state back to PLAY_STATE_LOADING. This will greatly simplify the code of MediaDecoder. This will also reduce the coupling between MediaDecoder and MDSM since MediaDecoder can care less about the internal state of MDSM.
|
(Assignee) | |
Updated•2 years ago
|
||
|
|
(Assignee) | |
Comment 1•2 years ago
|
||
Created attachment 8773205 [details] Bug 1288344. Part 1 - Don't change play state when entering/exiting dormant state. Review commit: https://reviewboard.mozilla.org/r/65926/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65926/
Attachment #8773205 -
Flags: review?(cpearce)
Attachment #8773206 -
Flags: review?(cpearce)
|
|
(Assignee) | |
Comment 2•2 years ago
|
||
Created attachment 8773206 [details] Bug 1288344. Part 2 - Remove MediaDecoder::mWasEndedWhenEnteredDormant. Review commit: https://reviewboard.mozilla.org/r/65928/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65928/
|
||
Updated•2 years ago
|
||
Attachment #8773205 -
Flags: review?(cpearce) → review+
|
|
||
Comment 3•2 years ago
|
||
Comment on attachment 8773205 [details] Bug 1288344. Part 1 - Don't change play state when entering/exiting dormant state. https://reviewboard.mozilla.org/r/65926/#review63532
|
|
||
Comment 4•2 years ago
|
||
Comment on attachment 8773206 [details] Bug 1288344. Part 2 - Remove MediaDecoder::mWasEndedWhenEnteredDormant. https://reviewboard.mozilla.org/r/65928/#review63534
Attachment #8773206 -
Flags: review?(cpearce) → review+
|
|
(Assignee) | |
Comment 5•2 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56a4a187f9bc Part 1 - Don't change play state when entering/exiting dormant state. r=cpearce https://hg.mozilla.org/integration/autoland/rev/4b60c69db493 Part 2 - Remove MediaDecoder::mWasEndedWhenEnteredDormant. r=cpearce
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/56a4a187f9bc https://hg.mozilla.org/mozilla-central/rev/4b60c69db493
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•