1288344 - Don't change the play state of MediaDecoder when entering/exiting dormant state

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

The current logic of MediaDecoder is able to handle entering/exiting dormant state without changing its play state back to PLAY_STATE_LOADING. This will greatly simplify the code of MediaDecoder.

This will also reduce the coupling between MediaDecoder and MDSM since MediaDecoder can care less about the internal state of MDSM.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1288344. Part 1 - Don't change play state when entering/exiting dormant state.

Review commit: https://reviewboard.mozilla.org/r/65926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65926/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1288344. Part 2 - Remove MediaDecoder::mWasEndedWhenEnteredDormant.

Review commit: https://reviewboard.mozilla.org/r/65928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65928/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8773205 [details]
Bug 1288344. Part 1 - Don't change play state when entering/exiting dormant state.

https://reviewboard.mozilla.org/r/65926/#review63532

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8773206 [details]
Bug 1288344. Part 2 - Remove MediaDecoder::mWasEndedWhenEnteredDormant.

https://reviewboard.mozilla.org/r/65928/#review63534

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56a4a187f9bc
Part 1 - Don't change play state when entering/exiting dormant state. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/4b60c69db493
Part 2 - Remove MediaDecoder::mWasEndedWhenEnteredDormant. r=cpearce

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/56a4a187f9bc
https://hg.mozilla.org/mozilla-central/rev/4b60c69db493