Closed
Bug 1288381
Opened 8 years ago
Closed 8 years ago
Allow property accessors and calls after super()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(2 files)
10.13 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
3.77 KB,
patch
|
Details | Diff | Splinter Review |
Test case: --- class C extends Object { constructor() { super().foo; super()[0]; super()(); super()``; } } --- Expected: Does not throw a SyntaxError Actual: Throws a SyntaxError
Comment 1•8 years ago
|
||
class A extends B { constructor() { super().foo() } } // throws "SyntaxError: missing ; before statement" class A extends B { constructor() { super() .foo() } } // SyntaxError: expected expression, got '.'
Assignee | ||
Comment 2•8 years ago
|
||
Another simple frontend bug, I'll post another patch which omits whitespace only changes so it's easier to spot the changes.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8797160 -
Flags: review?(arai.unmht)
Assignee | ||
Comment 3•8 years ago
|
||
Changes to Parser.cpp from the actual patch, but with whitespace only changes suppressed.
Comment 4•8 years ago
|
||
Comment on attachment 8797160 [details] [diff] [review] bug1288381.patch Review of attachment 8797160 [details] [diff] [review]: ----------------------------------------------------------------- thanks :)
Attachment #8797160 -
Flags: review?(arai.unmht) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffb3438b5f8a07a54364032fcb878a1f15690743
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6dd3d752338c Allow member expressions after super() call. r=arai
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6dd3d752338c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•