Closed
Bug 1288427
Opened 9 years ago
Closed 9 years ago
Remove the base shapes update phase of compacting GC
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
2.33 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
I added a separate base shapes update phase to address bug 1261083. However looking at the code again I can't see why it was necessary, and taking it out doesn't cause the TSAN warnings to come back. I guess some intervening change has made this unnecessary.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8773294 -
Flags: review?(terrence)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8773294 [details] [diff] [review]
bug1288427-remove-base-shape-phase
Review of attachment 8773294 [details] [diff] [review]:
-----------------------------------------------------------------
Maybe the new table marking code?
Attachment #8773294 -
Flags: review?(terrence) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31163bfc3cb4
Remove the base shapes update phase of compacting GC r=terrence
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•