128844 - static build breakage for OpenVMS

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[Colin Blake]

Recent changes to how static links are performed has broken the
OpenVMS build. I have had to modify the following files:

  config/static-config.mk

    Remove TK_LIBS from STATIC_EXTRA_LIBS in config/static-config.mk
    (component Makefile always includes this and we don't want it twice).

  embedding/browser/gtk/tests/Makefile.in

    Move MOZ_COMPONENT_LIBS from LIBS to the end of EXTRA_LIBS. This is
    because in a static link only what is needed is loaded from a library,
    and therefore order is relevant. Since much of the code is brought in
    via the libraries in EXTRA_LIBS, we need to defer the loading NSPR and
    XPCOM until after these other libraries are loaded, otherwise we end
    up with unresolved symbols.

    Prefix -L$(DEPTH)/dist/lib/components to EXTRA_LIBS

  xpfe/bootstrap/Makefile.in

    Add -L../../../../dist/lib/components to EXTRA_DSO_LDOPTS

I will attach a patch next, but maybe there's a better way to fix this?

Colin.

Comment 1

[Colin Blake]

Attachment: Fix build breakage for OpenVMS

Comment 2

[hacker formerly known as [e-mail]]

Attachment: v2

I had to make a couple of minor tweaks.  I removed the 'colin' target & I made
sure that MOZ_COMPONENT_LIBS was added to EXTRA_LIBS

Comment 3

[hacker formerly known as [e-mail]]

err, that was weird...

Anyway, I made sure that MOZ_COMPONENT_LIBS was added to EXTRA_LIBS for the
non-static build as well.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 72773 [details] [diff] [review]
v2

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 5

[Colin Blake]

Modified patch works for me. Thanks Chris.

Comment 6

[hacker formerly known as [e-mail]]

The patch has been checked into the trunk.