Closed
Bug 1288450
Opened 8 years ago
Closed 8 years ago
Add minimum android sdk field to mozinfo
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: bc, Assigned: gbrown)
Details
Attachments
(1 file)
1.17 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
Prior to taskcluster, build urls contained meta data about build type, platform and for fennec the minimum supported sdk on the device required to run the build. The build type and platform are available in target.mozinfo.json however there is no record of the required minimum sdk. See for example: https://public-artifacts.taskcluster.net/XRw5ACNWTLW3FCiIgR_1nw/0/public/build/target.mozinfo.json We currently support two classes of android builds: android sdk 10 and sdk 15 and higher. Android sdk 10 is only supported on release Firefox 47 and will be gone altogether when Firefox 48 is released August 2. However we can envision the future need to also provide different builds depending on the android sdk of the device and should plan for it now. The environment variable MOZ_ANDROID_MIN_SDK_VERSION is available to the build process and can be used to set the field.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → gbrown
Attachment #8773376 -
Flags: review?(ahalberstadt)
Comment 2•8 years ago
|
||
Comment on attachment 8773376 [details] [diff] [review] add 'android_min_sdk' to mozinfo Review of attachment 8773376 [details] [diff] [review]: ----------------------------------------------------------------- Lgtm!
Attachment #8773376 -
Flags: review?(ahalberstadt) → review+
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/69094e855e27 Add min sdk version to mozinfo.json; r=ahal
Assignee | ||
Comment 4•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/6d5aca780e2d4627974e755cf0fe451ee67a83c4 for causing mozinfo test failures for non-android platforms like: http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-linux64/1469197165/mozilla-inbound-linux64-bm72-build1-build2383.txt.gz
Assignee | ||
Comment 5•8 years ago
|
||
Easily fixed by guarding against undefined 'buildapp': https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf54fb6bcefd
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c7a461e12223 Add min sdk version to mozinfo.json; r=ahal
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c7a461e12223
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•