Closed Bug 1288471 Opened 8 years ago Closed 8 years ago

Port bug 1262731 to IB and TB - Don't use a separate ICU data file on Windows

Categories

(Thunderbird :: Installer, defect)

Product:
Thunderbird
Component:
Installer
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird47 unaffected, thunderbird48 fixed, thunderbird49 fixed, thunderbird50 fixed, thunderbird_esr45 unaffected)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 50.0
Tracking Flags:
Tracking Status
thunderbird47 --- unaffected
thunderbird48 --- fixed
thunderbird49 --- fixed
thunderbird50 --- fixed
thunderbird_esr45 --- unaffected

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

icu.patch
2.60 KB, patch
aleth
: review+
jorgk-bmo
: approval-comm-aurora+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review 
From bug 1262731: "It's a mix of Firefox and Thunderbird, and even one SeaMonkey. It's mostly in 48.0a1, which suggests it's gotten a lot more frequent recently."
Attached patch icu.patch — — Splinter Review 
Straight port from FX.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8773351 - Flags: review?(aleth)
Comment on attachment 8773351 [details] [diff] [review]
icu.patch

Review of attachment 8773351 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8773351 - Flags: review?(aleth) → review+
Comment on attachment 8773351 [details] [diff] [review]
icu.patch

[Approval Request Comment]
Regression caused by (bug #): see linked bug
User impact if declined: topcrash!
Risk to taking this patch (and alternatives if risky): just following m-c here
Attachment #8773351 - Flags: approval-comm-beta?
Attachment #8773351 - Flags: approval-comm-aurora?
Pushed to fix bustage

https://hg.mozilla.org/comm-central/rev/c5465a63afb3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
Attachment #8773351 - Flags: approval-comm-beta?
Attachment #8773351 - Flags: approval-comm-beta+
Attachment #8773351 - Flags: approval-comm-aurora?
Attachment #8773351 - Flags: approval-comm-aurora+
Beta (TB 48):
https://hg.mozilla.org/releases/comm-beta/rev/ecc56fcf0f7e
Landed with DONTBUILD, next automated blocklist update (tomorrow?) will compile it.
status-thunderbird48: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: