Closed Bug 1288474 Opened 4 years ago Closed 4 years ago

TextxureClientPool should actually stop once Destroy() has been called on it

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: gw280, Assigned: gw280)

Details

Attachments

(1 file)

I noticed some interesting behaviour that is non-obvious when I was changing the TextureClientPool's allocation strategy.

On shutdown, we call TextureClientPool::Destroy(). This sets the pool size to 0, and drops all its refs to any TextureClients it owns.

However, what is not obvious is that TextureClients are still returned after Destroy() has been called. This is "handled" by accepting them then calling ShrinkToMaximumSize() which then immediately discards them.

We should probably just not accept them in the first place.
Assignee: nobody → gwright
Attachment #8773396 - Flags: review?(nical.bugzilla)
Attachment #8773396 - Flags: review?(nical.bugzilla) → review+
Pushed by gwright@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d91042a4ca77
Don't accept TextureClient returns if the pool has been destroyed r=nical
https://hg.mozilla.org/mozilla-central/rev/d91042a4ca77
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.