Closed Bug 1288508 Opened 3 years ago Closed 3 years ago

Make nsIAccessible* interfaces builtinclass so they can be static_cast'ed to xpcAccessibleGeneric

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: michael.li11702, Assigned: michael.li11702)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview-Commit-ID: KF2HnLBTf6i
Assignee: nobody → mili
In bug 1286952, we want to be able to static cast a nsIAccessible to a xpcAccessibleGeneric and this is easily achieved by making nsIAccessible builtinclass, and at that rate we might as well make the other nsIAccessible* interfaces builtinclass as well.
Blocks: 1286952
Comment on attachment 8773438 [details] [diff] [review]
Make nsIAccessible* interfaces builtinclass so they can be static_cast'ed to xpcAccessibleGeneric

Looks good to me, thanks
Attachment #8773438 - Flags: review?(yzenevich) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bbebd48ca62
Make nsIAccessible* interfaces builtinclass so they can be static_cast'ed to xpcAccessibleGeneric. r=yzen
Keywords: checkin-needed
Backout by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/388944aa4d97
Backed out changeset 1bbebd48ca62 for causing mochitest-a11y timeouts on a CLOSED TREE.
This version doesn't make the pivot and states classes builtinclass as they're implemented in js, in accessible/jsat/Utils.jsm.
Attachment #8774932 - Flags: review+
Attachment #8773438 - Attachment is obsolete: true
Try server results for this latest patch plus code in bug 1286952 are at https://treeherder.mozilla.org/#/jobs?repo=try&revision=423558ba31c2
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e16a16e8146a
Make nsIAccessible* interfaces builtinclass so they can be static_cast'ed to xpcAccessibleGeneric. r=yzenevich
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e16a16e8146a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.