Closed Bug 1288508 Opened 3 years ago Closed 3 years ago
IAccessible* interfaces builtinclass so they can be static _cast'ed to xpc Accessible Generic
In bug 1286952, we want to be able to static cast a nsIAccessible to a xpcAccessibleGeneric and this is easily achieved by making nsIAccessible builtinclass, and at that rate we might as well make the other nsIAccessible* interfaces builtinclass as well.
Comment on attachment 8773438 [details] [diff] [review] Make nsIAccessible* interfaces builtinclass so they can be static_cast'ed to xpcAccessibleGeneric Looks good to me, thanks
Attachment #8773438 - Flags: review?(yzenevich) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/1bbebd48ca62 Make nsIAccessible* interfaces builtinclass so they can be static_cast'ed to xpcAccessibleGeneric. r=yzen
Backed out for causing mochitest-a11y timeouts. https://treeherder.mozilla.org/logviewer.html#?job_id=32477621&repo=mozilla-inbound#L4214 https://treeherder.mozilla.org/logviewer.html#?job_id=32475337&repo=mozilla-inbound#L19246
Backout by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/388944aa4d97 Backed out changeset 1bbebd48ca62 for causing mochitest-a11y timeouts on a CLOSED TREE.
This version doesn't make the pivot and states classes builtinclass as they're implemented in js, in accessible/jsat/Utils.jsm.
Attachment #8774932 - Flags: review+
Try server results for this latest patch plus code in bug 1286952 are at https://treeherder.mozilla.org/#/jobs?repo=try&revision=423558ba31c2
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/e16a16e8146a Make nsIAccessible* interfaces builtinclass so they can be static_cast'ed to xpcAccessibleGeneric. r=yzenevich
You need to log in before you can comment on or make changes to this bug.