Closed Bug 1288554 Opened 9 years ago Closed 9 years ago

[tinder] _meta.get_field_by_name is deprecated, time to rewrite pmap

Categories

(Webtools Graveyard :: Elmo, defect)

Product:
Webtools Graveyard
Component:
Elmo
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

Details

In the old days, django wasn't exposing through models, so I hacked up something really awkward to get some of the build properties for the tbpl display. Today, this can be just a few lines of code. This is triggered by the fact that django deprecated _meta.get_field_by_name, and instead of fixing that, I fixed the manually written sql instead.
Commit pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/557af4ade0d9de8a2f5e94e86d19b6e74a13e4d6 bug 1288554, modern django has field.through, no custom sql. 49 lines of undecipherable code, replaced by 9 lines of beauty. Django's ORM got better with through models, and I got better in using them. Sweet. Just before we remove the tinder app for good.
Assignee: nobody → l10n
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.