1288580 - Mark Widevine as supported on Linux

Status: RESOLVED FIXED

Description

[[PTO until 15 Jan] Chris Pearce (:cpearce)]

As preparation for rolling out Widevine on Linux, we need to set Widevine on Linux as supported, so when it's preffed visible it will appear in the plugins list.

Comment 1

[[PTO until 15 Jan] Chris Pearce (:cpearce)]

Created attachment 8773573 [details]
Bug 1288580 - Mark Widevine as supported on Linux and remove MacOSX version check.

This means if Widevine is preffed visible on Linux it will show up in the
plugin list.

We only support MacOSX 10.9 and later, so we don't need the >= 10.7 check any
more.

Review commit: https://reviewboard.mozilla.org/r/66274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66274/

Comment 2

[Stephen A Pohl [:spohl]]

Comment on attachment 8773573 [details]
Bug 1288580 - Mark Widevine as supported on Linux and remove MacOSX version check.

https://reviewboard.mozilla.org/r/66274/#review63082

::: toolkit/modules/GMPUtils.jsm:86
(Diff revision 1)
>                                    GMPPluginUnsupportedReason.NOT_WINDOWS);
>          return false;
>        }
>      } else if (aPlugin.id == WIDEVINE_ID) {
> -      // The Widevine plugin is available for Windows versions Vista and later
> -      // and Mac OSX 10.7 and later.
> +      // The Widevine plugin is available for Windows versions Vista and later,
> +      // MacOSX, and Linux.

nit: there should still be a space between Mac and OSX, i.e. "Mac OSX". Sierra changes this to macOS, but I don't think we need to worry about that.

Comment 3

[[PTO until 15 Jan] Chris Pearce (:cpearce)]

Comment on attachment 8773573 [details]
Bug 1288580 - Mark Widevine as supported on Linux and remove MacOSX version check.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66274/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3d51e9cdbef
Mark Widevine as supported on Linux and remove MacOSX version check. r=spohl

Comment 5

[Iris Hsiao [:ihsiao]]

Hi Chris, sorry had to back out your push, because the mochitest failure, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=874033&repo=autoland#L6258

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaf2540b99a3
Backed out changeset d3d51e9cdbef for Mochitest browser_gmpProvider.js failure

Comment 7

[[PTO until 15 Jan] Chris Pearce (:cpearce)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=346f87ec0f9c

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a490ba324a
Mark Widevine as supported on Linux and remove Mac OSX version check. r=spohl

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5a490ba324a

Comment 10

[[PTO until 15 Jan] Chris Pearce (:cpearce)]

Created attachment 8779566 [details] [diff] [review]
Mark Widevine as supported on Linux and remove Mac OSX version check

This means if Widevine is preffed visible on Linux it will show up in the
plugin list.

We only support Mac OSX 10.9 and later, so we don't need the >= 10.7 check any
more.

MozReview-Commit-ID: BjgMKeIIrrI

Comment 11

[[PTO until 15 Jan] Chris Pearce (:cpearce)]

Comment on attachment 8779566 [details] [diff] [review]
Mark Widevine as supported on Linux and remove Mac OSX version check

Approval Request Comment
[Feature/regressing bug #]: Widevine EME on Linux
[User impact if declined]: Firefox won't download the Widevine CDM on Linux.
[Describe test coverage new/current, TreeHerder]: We have tests covering this specific feature.
[Risks and why]: Low; have tests, and this is a simple change.plat
[String/UUID change made/needed]: None

Comment 12

[Liz Henry (:lizzard) (needinfo? me)]

Comment on attachment 8779566 [details] [diff] [review]
Mark Widevine as supported on Linux and remove Mac OSX version check

OK to uplift, we'll test it in beta 3

Comment 13

[[PTO until 15 Jan] Chris Pearce (:cpearce)]

https://hg.mozilla.org/releases/mozilla-beta/rev/98f5bd2a3d5e

Comment 14

[[PTO until 15 Jan] Chris Pearce (:cpearce)]

https://hg.mozilla.org/releases/mozilla-beta/rev/98f5bd2a3d5e