Closed Bug 1288580 Opened 4 years ago Closed 4 years ago

Mark Widevine as supported on Linux

Categories

(Toolkit :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file, 1 obsolete file)

As preparation for rolling out Widevine on Linux, we need to set Widevine on Linux as supported, so when it's preffed visible it will appear in the plugins list.
This means if Widevine is preffed visible on Linux it will show up in the
plugin list.

We only support MacOSX 10.9 and later, so we don't need the >= 10.7 check any
more.

Review commit: https://reviewboard.mozilla.org/r/66274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66274/
Attachment #8773573 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8773573 [details]
Bug 1288580 - Mark Widevine as supported on Linux and remove MacOSX version check.

https://reviewboard.mozilla.org/r/66274/#review63082

::: toolkit/modules/GMPUtils.jsm:86
(Diff revision 1)
>                                    GMPPluginUnsupportedReason.NOT_WINDOWS);
>          return false;
>        }
>      } else if (aPlugin.id == WIDEVINE_ID) {
> -      // The Widevine plugin is available for Windows versions Vista and later
> -      // and Mac OSX 10.7 and later.
> +      // The Widevine plugin is available for Windows versions Vista and later,
> +      // MacOSX, and Linux.

nit: there should still be a space between Mac and OSX, i.e. "Mac OSX". Sierra changes this to macOS, but I don't think we need to worry about that.
Attachment #8773573 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8773573 [details]
Bug 1288580 - Mark Widevine as supported on Linux and remove MacOSX version check.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66274/diff/1-2/
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3d51e9cdbef
Mark Widevine as supported on Linux and remove MacOSX version check. r=spohl
Hi Chris, sorry had to back out your push, because the mochitest failure, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=874033&repo=autoland#L6258
Flags: needinfo?(cpearce)
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aaf2540b99a3
Backed out changeset d3d51e9cdbef for Mochitest browser_gmpProvider.js failure
Flags: needinfo?(cpearce)
Product: Firefox → Toolkit
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a490ba324a
Mark Widevine as supported on Linux and remove Mac OSX version check. r=spohl
https://hg.mozilla.org/mozilla-central/rev/e5a490ba324a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
This means if Widevine is preffed visible on Linux it will show up in the
plugin list.

We only support Mac OSX 10.9 and later, so we don't need the >= 10.7 check any
more.

MozReview-Commit-ID: BjgMKeIIrrI
Attachment #8773573 - Attachment is obsolete: true
Comment on attachment 8779566 [details] [diff] [review]
Mark Widevine as supported on Linux and remove Mac OSX version check

Approval Request Comment
[Feature/regressing bug #]: Widevine EME on Linux
[User impact if declined]: Firefox won't download the Widevine CDM on Linux.
[Describe test coverage new/current, TreeHerder]: We have tests covering this specific feature.
[Risks and why]: Low; have tests, and this is a simple change.plat
[String/UUID change made/needed]: None
Attachment #8779566 - Flags: review+
Attachment #8779566 - Flags: approval-mozilla-beta?
Comment on attachment 8779566 [details] [diff] [review]
Mark Widevine as supported on Linux and remove Mac OSX version check

OK to uplift, we'll test it in beta 3
Attachment #8779566 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.