1288585 - [Decoder Doctor] WMF-missing console message is misleading on Windows XP

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

When attempting to play an H.264/AAC/MP4 file on Windows XP, the following warning is shown in the console:
"To play video formats video/mp4; codecs="avc1.42E01E mp4a.40.2", video/mp4, you need to install extra Microsoft software, see https://support.mozilla.org/kb/fix-video-audio-problems-firefox-windows"

However unlike Windows Vista+, XP does not have the option to add Microsoft software to handle these formats.
So we should not show this console message.
Maybe another one? TBD.

Note that the drop-down notification bar is not shown, as expected.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1288585 - Clarify console message about WinXP unsupported formats -

On Windows XP (and others before Vista), if WMF is required to play a format,
the console message should not refer to Microsoft software as it is not
available there.

Review commit: https://reviewboard.mozilla.org/r/66774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66774/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3f52f5e90ead018b28da3c097dce06616ab1958

And also manually tested on Windows XP to verify that the new message is shown there.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8774246 [details]
Bug 1288585 - Clarify console message about WinXP unsupported formats -

https://reviewboard.mozilla.org/r/66774/#review63550

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cde1abb38839
Clarify console message about WinXP unsupported formats - r=cpearce

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cde1abb38839