Closed
Bug 1288595
Opened 8 years ago
Closed 8 years ago
Conflict DECLARE_HANDLE(DPI_AWARENESS_CONTEXT) with the latest Windows SDK beta (10.0.14383.0)
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(1 file)
ntdef.h header in 10.0.14383.0 is the following
#ifdef STRICT
...
#define DECLARE_HANDLE(name) struct name##__{int unused;}; typedef struct name##__ *name
So it causes conflict on WinUtils.h
|
Assignee | |
Updated•8 years ago
|
Summary: Conflict ECLARE_HANDLE(DPI_AWARENESS_CONTEXT) with the latest Windows SDK beta (10.0.14383.0) → Conflict DECLARE_HANDLE(DPI_AWARENESS_CONTEXT) with the latest Windows SDK beta (10.0.14383.0)
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/66332/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/66332/
Attachment #8773597 -
Flags: review?(jfkthame)
|
||
Comment 2•8 years ago
|
||
(In reply to Makoto Kato [:m_kato] from comment #1) > Bug 1288595 - Conflict DECLARE_HANDLE(DPI_AWARENESS_CONTEXT) with the latest > Windows SDK beta (10.0.14383.0). The summary should describe the fix rather than the bug. (For example, "Fix conflict ...")
|
||
Updated•8 years ago
|
Attachment #8773597 -
Flags: review?(jfkthame) → review+
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8773597 [details] Bug 1288595 - Conflict DECLARE_HANDLE(DPI_AWARENESS_CONTEXT) with the latest Windows SDK beta (10.0.14383.0). https://reviewboard.mozilla.org/r/66332/#review63106 Oh, I guess they removed the DPI_AWARENESS_CONTEXT_DECLARED guard from this SDK version... sigh. Anyhow, this looks fine (but please adjust the commit message, as above).
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/1198cb175ed7 Guard DPI_AWARENESS_CONTEXT defines against Windows SDK beta (10.0.14383.0). r=jfkthame
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1198cb175ed7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•