Closed
Bug 1288603
Opened 9 years ago
Closed 9 years ago
Remove NumericLimits.h because all platforms have numeric_limits<char16_t>
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
21.73 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
NumericLimits.h was added (bug 924014) to provide std::numeric_limits<char16_t> because VS2013 did not have char16_t (and we instead typedef'd char16_t to wchar_t). Now that we have dropped VS2013 support (bug 1186064) and use VS2015's distinct char16_t type (bug 1277106), we can remove NumericLimits.h because all platforms have numeric_limits<char16_t>.
Green Try build, except for unrelated msan/tsan bustage:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e6507feab77
Attachment #8773601 -
Flags: review?(nfroyd)
|
||
Updated•9 years ago
|
Attachment #8773601 -
Flags: review?(nfroyd) → review+
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8af5416b062
Remove NumericLimits.h because all platforms have numeric_limits<char16_t>. r=froydnj
|
||
Comment 2•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•