Closed Bug 1288608 Opened 3 years ago Closed 3 years ago
"ASSERTION: unexpected kid position" in ns
Table Row Frame::Reflow Children
###!!! ASSERTION: unexpected kid position: 'origKidNormalPosition.B(wm) == 0 || wm.IsVerticalRL()', file layout/tables/nsTableRowFrame.cpp, line 878
I can only reproduce on my Mac Minis, not on my MacBook Pro. This might be related to the testcase's use of "vw" units. It does NOT seem to depend on the size of the browser window, which seems even weirder.
I think we just need to ensure that the normal position is stored on a frame property before the SetPosition call. https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae967b53a1e3
Assignee: nobody → mats
Attachment #8782095 - Flags: review?(jfkthame)
Attachment #8782095 - Flags: review?(jfkthame) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f152cd3cfc Ensure the normal position is stored on a property before setting the relative position. r=jfkthame https://hg.mozilla.org/integration/mozilla-inbound/rev/b354997ed10c Crashtest.
Mats, could you fill the uplift request to aurora? Thanks
Comment on attachment 8782095 [details] [diff] [review] fix Approval Request Comment [Feature/regressing bug #]: don't know [User impact if declined]: mispositioned elements when dynamically changing style/DOM (probably rare) [Describe test coverage new/current, TreeHerder]: includes crashtest [Risks and why]: low risk, trivial fix [String/UUID change made/needed]: none
Attachment #8782095 - Flags: approval-mozilla-aurora?
Comment on attachment 8782095 [details] [diff] [review] fix Stabilized on nightly for a few days, Aurora50+
Attachment #8782095 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.