Closed Bug 1288650 Opened 3 years ago Closed 3 years ago

Export mac/nsOSHelperAppService.h instaed of win/nsOSHelperAppService.h on OSX builder

Categories

(Firefox Build System :: General, defect)

Unspecified
macOS
defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Maybe, this is typo by bug 846634...
Comment on attachment 8773651 [details]
Bug 1288650 - Export mac/nsOSHelperAppService.h instaed of win/nsOSHelperAppService.h on OSX builder.

Whoa, thanks for fixing that - not sure how I messed it up. Can we also remove these lines?

https://dxr.mozilla.org/mozilla-central/rev/4c05938a64a7fde3ac2d7f4493aee1c5f2ad8a0a/docshell/build/moz.build#23

I think that's the only reason that directory picks up the correct header on OSX instead of the incorrectly installed Windows version, which is probably why this went unnoticed for so long. That LOCAL_INCLUDE was in the original Makefile.in as well though, so it might be needed for something else.
Attachment #8773651 - Flags: review?(mshal) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bea94bc8811
Export mac/nsOSHelperAppService.h instaed of win/nsOSHelperAppService.h on OSX builder. r=mshal
https://hg.mozilla.org/mozilla-central/rev/0bea94bc8811
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.