1288730 - Vertical line displayed in the right side of the downloads panel

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Simona Badau, Desktop QA]

Attachment: DownloadsPanelScreenshot.png

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160722030235

[Affected versions]:
- Nightly 50

[Affected platforms]:
- reproduced on Windows 7 and Windows 10

[Steps to reproduce]:
1. Launch Nightly with a new profile
2. On the first run page, click on the Downloads Panel

[Expected result]:
- The downloads panel should be displayed properly.

[Actual result]:
- A vertical line is displayed in the right side of the panel - please see the screenshot for more details.

[Regression range]: 
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=77a5e8e87f91113dcf6cb15fdc83a184cc237e48&tochange=e2ddf53209916302a81ca331f88b4df8df0ca7c7

Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1280825

[Additional notes]:
- Not reproducible on Mac OS X or on Ubuntu.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: visible regression in Firefox 50

Comment 2

[Marcia Knous [:marcia]]

Tracking 50+ for this visible regression in the Downloads Panel.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1288730 - Vertical line displayed in the right side of the downloads panel.

Review commit: https://reviewboard.mozilla.org/r/66986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66986/

Comment 4

[Drew Willcoxon :adw]

The problem is the overflow: visible.  I think what's happening is that the left sliver of the subview is visible.

It doesn't actually seem to be necessary at all.  I tested this on Windows and OS X.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8774553 [details]
Bug 1288730 - Vertical line displayed in the right side of the downloads panel.

https://reviewboard.mozilla.org/r/66986/#review64060

::: browser/components/downloads/content/downloads.css
(Diff revision 1)
>  /* Make the panel wide enough to show the download list items without improperly
>     truncating them. */
>  #downloadsPanel-multiView > .panel-viewcontainer,
>  #downloadsPanel-multiView > .panel-viewcontainer > .panel-viewstack,
>  #downloadsPanel-multiView > .panel-viewcontainer > .panel-viewstack > .panel-mainview {
> -  overflow: visible;

Do you know what is overflowing? It may be better to fix that instead of keeping overflow:hidden;

Comment 6

[Drew Willcoxon :adw]

It's the the left sliver of the subview.  But it needs to be positioned to the right of the main view so that it can slide in from the right to the left.

Comment 7

[Drew Willcoxon :adw]

Oh, if you meant why I added overflow:visible to begin with, I must have thought it fixed something at one point, but I don't remember what.  I'm just mashing buttons over here.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

I was looking for comment #6, I doing comment #7 as well :P

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6c3985e15fa
Vertical line displayed in the right side of the downloads panel. r=jaws

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6c3985e15fa

Comment 11

[Saheda Reza [:Antora]]

I have reproduced this bug on firefox nightly according to(2016-07-22)

Fixing bug is verified on Latest Nightly -- Build ID:( 20160727030230 ),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0


Tested OS-- windows10 32bit

Comment 13

[Subhrajyoti Sen]

Verified as FIXED on Firefox Developer Edition (2016-09-09) using Linux Mint 18 64-bit