1288732 - Screen sharing is still open in permissions dialog even after disabling it on https://web.ciscospark.com

Status: RESOLVED INVALID

(Core :: WebRTC, defect, P1)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- latest Aurora 49.0a2 (2016-07-21)

[Affected platforms]:
- Windows 7 x64
- Ubuntu 14.04 x86
- Mac OS X 10.11

[Steps to reproduce]:
1. Launch Firefox on 2 stations
2. Go to https://web.ciscospark.com and enter your credentials on both stations
3. Start a video call between stations (allow camera and microphone sharing when permissions dialog appears)
4. Toggle "Share Screen" web app button in order to enable screen sharing on station_1
- inspect the permissions icon/dialog on station_1
5. Toggle "Share Screen" web app button in order to disable screen sharing from on station_1
- inspect the permissions icon/dialog on station_1


[Expected result]:
- [step 4] The screen sharing permission icon appears in location bar and on the top of the screen 
- [step 5] The screen sharing permission icon disappears from location bar and from the top of the screen 

[Actual result]:
- After disabling screen sharing from the web app, the screen sharing permission icons/dialog are still displayed, even if they do nothing if toggled

[Regression range]:
- I will investigate this as soon as possible

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Unclear if a) they're actually calling stream.stop() when you click to stop the stream, or b) if they are calling it, if there's a bug on the platform side or the UI side.  My personal bet is they're not calling stop()

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Stopping screensharing works for me in this fiddle: https://jsfiddle.net/3xytpne5/

so I agree with jesup in comment 1 that they're likely not calling track.stop() (or the deprecated stream.stop()).

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Removing 'regression' as there's no evidence that it's a regression in our code.

Paul, can you verify if stop() is being called when someone stops sharing?

Comment 4

[Paul E. Jones]

Will check.

Comment 5

[Paul E. Jones]

Currently, stop() is not called if the user stops sharing. track.enabled is set to false. Reasoning is that if the user wishes to share again, they're not asked to grant permission again.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Ok, though note that this means the user won't be prompted to select what to share again (for example which window, or which screen if they have multiple monitors), and the "I'm sharing" indicator will continue to show, perhaps confusing the user.

The UI may want to expose this by having it say something like "Pause Sharing", and have a separate "Stop Sharing" (ugh, but less confusing than just "Stop" (and having "Start" not let you change)).  

I'm sure there are other variations on how the app's UI handles this which might be better. 

In any case, not a bug.