Closed Bug 1288736 Opened 8 years ago Closed 8 years ago

Add some missing rv.SuppressException()

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

Attached patch fix2.patchSplinter Review
      No description provided.
Attachment #8773760 - Flags: review?(bugs)
Comment on attachment 8773760 [details] [diff] [review]
fix2.patch

   ErrorResult rv;
   FileSystemResponseValue value = GetSuccessRequestResult(rv);
   if (NS_WARN_IF(rv.Failed())) {
+    rv.SuppressException();
     return FileSystemErrorResponse(rv.StealNSResult());
sure looks wrong.

fix that, r+
Attachment #8773760 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bafc5c504506
Add some missing rv.SuppressException(), r=smaug
https://hg.mozilla.org/mozilla-central/rev/bafc5c504506
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: