1288743 - Change icon size and options for composer toolbar

Status: RESOLVED WONTFIX

(SeaMonkey :: Composer, defect)

Description

[Frank-Rainer Grahl (:frg)]

Attachment: editor-before.PNG

In a mozillazine thread Frank Lion suggested changing the options for the composer toolbar. The defaults are a little clumsy looking.

See:

http://forums.mozillazine.org/viewtopic.php?f=40&t=3013223

Changing the defaults to the suggested values make it look a lot better.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: editor-after.PNG

with changed css

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1288743-composertoolbar.patch

Patch

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: icons.png

For comparision:
untitled-2: current
untitled-1: with patch 
Bookmarks: Regular Icons same size as untitled-2

Comment 4

[Stefan [:stefanh]]

Comment on attachment 8773774 [details] [diff] [review]
1288743-composertoolbar.patch

>--- a/suite/themes/classic/editor/editorPrimaryToolbar.css
>+++ b/suite/themes/classic/editor/editorPrimaryToolbar.css

You forgot to change suite/themes/classic/mac/editor/editorPrimaryToolbar.css

> 
>+/* ::::: primary toolbar masthead ::::: */
>+
>+#EditToolbar toolbarbutton  > .toolbarbutton-icon,
>+#EditToolbar #navigator-throbber,#EditToolbar #print-button > .toolbarbutton-menubutton-button > .toolbarbutton-icon  {
>+  transform : scale(0.8, 0.8) !important;
>+  margin-top: -4px !important;
>+  margin-bottom: -4px !important;}

The css selectors are quite expensive. It would also be better to adjust the icon sizes directly, then you wouldn't need the transform rule (which is a bit hacky in this context since you really just want smaller icons).

But I honestly don't think this is a good idea. Firstly, this would introduce an inconsistency in the application suite: icon size (smaller icons in Composer compared to Navigator and so on). I do agree that the icons are a bit big, but that's not just in Composer. It would probably be much better to fix bug 606683 so you could choose small icons.

Comment 5

[Frank-Rainer Grahl (:frg)]

Then lets make it wontfix for now.