1288752 - While undocked, Dev tools panel vanishes behind the browser window when clicking on 'Visit MDN page'

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P1)

Description

[Ada [:adalucinet]]

[Affected versions]:
- latest Nightly 50.0a1

[Affected platforms]:
- Windows 10 64-bit
- Mac OS X 10.9.5

[Steps to reproduce]:
1. Launch Firefox.
2. Open Inspector: Ctrl + Shift + C (for Windows) or Cmd + Opt + C (for Mac OS X).
3. Click on 'Show in separate window' button.
4. Right click on any property name.
5. Select 'Show MDN Docs' option from the context menu.
6. Click on 'Visit MDN page' link.

[Expected result]: Dev tools panel remains visible.

[Actual result]: Dev tools panel vanishes behind the browser window.

[Regression range]:
- with Nightly builds generated by mozregression tool (both gui and original command line tools), I'm unable to reproduce; 
-- Nightly from 2016-07-19 is affected by bug 1287438
-- Nightly from 2016-07-20 is the 1st one affected
-- Not reproducible with latest 49.0a2

[Additional notes]:
- Screen recording: https://goo.gl/x615cG

Comment 1

[Julian Descottes [:jdescottes]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69aeb2709622d4441139b26ce70ef68d2b83c151

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1288752 - mdndocs tooltip: consistent behavior on Visit MDN Page link click;

Review commit: https://reviewboard.mozilla.org/r/66864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66864/

Comment 3

[Julian Descottes [:jdescottes]]

Some context about our approach for this bug. Links to external websites should behave consistently in devtools, so we decided to stick with the behavior used for links in the console: 
- the link is opened in a new tab of the browser
- the browser window is brought to the front (so if devtools were in a separate window, they will still vanish behind the browser window)
- the newly opened tab should be selected

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8774384 [details]
Bug 1288752 - mdndocs tooltip: consistent behavior on Visit MDN Page link click;

https://reviewboard.mozilla.org/r/66864/#review64080

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/7971ab36aaca
mdndocs tooltip: consistent behavior on Visit MDN Page link click;r=bgrins

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7971ab36aaca

Comment 7

[Ada [:adalucinet]]

Verified fixed with latest Dev Edition 50.0a2 and Nightly 51.0a1, under Windows 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.9.5.