1288755 - Verify the list of Aurora locales (SUPPORTED_AURORA_LOCALES) in ship-it

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect)

Description

[Francesco Lodolo [:flod]]

While looking at bug 1288547, I discovered that there is an hard-coded list for SUPPORTED_AURORA_LOCALES in ship-it
https://github.com/flodolo/ship-it/blob/master/kickoff/config.py#L4

But that list seems out of date.

There were definitions on SVN for product-details.

SVN mobile (looks quite wrong)
http://viewvc.svn.mozilla.org/vc/libs/product-details/mobileDetails.class.php?revision=150157&view=markup#l48

SVN desktop
http://viewvc.svn.mozilla.org/vc/libs/product-details/firefoxDetails.class.php?revision=150449&view=markup#l55

I'm not sure if the mobile information was ever used, since we only expose multi-locale builds on mozilla.org in https://www.mozilla.org/it/firefox/channel/

Desktop aurora builds: http://hg.mozilla.org/releases/mozilla-aurora/raw-file/default/browser/locales/all-locales

Single locale Fennec aurora builds: http://hg.mozilla.org/releases/mozilla-aurora/raw-file/default/mobile/android/locales/all-locales

Multi locale Fennec aurora builds: http://hg.mozilla.org/releases/mozilla-release/raw-file/default/mobile/android/locales/maemo-locales

It's still unclear to me if SUPPORTED_AURORA_LOCALES is supposed to represent locales shipping in desktop or mobile. If it is, the are some missing and extra locales.

Missing locales:
cak
gn
ja-JP-mac
lo
ltg
ne-NP
tsz
ur
wo

Extra locales:
oc

It would be relatively easy to fix the list, but I don't know a) what it is supposed to represent and b) what it could break.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #0)
> I'm not sure if the mobile information was ever used, since we only expose
> multi-locale builds on mozilla.org in
> https://www.mozilla.org/it/firefox/channel/
To clarify, we expose the multilocale build to any locale, even if they're not localizing Fennec, e.g. https://www.mozilla.org/bn-BD/firefox/channel/#developer

> Multi locale Fennec aurora builds:
> http://hg.mozilla.org/releases/mozilla-release/raw-file/default/mobile/
> android/locales/maemo-locales

Wrong branch (release instead of aurora)
http://hg.mozilla.org/releases/mozilla-aurora/raw-file/default/mobile/android/locales/maemo-locales

Comment 2

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

SUPPORTED_AURORA_LOCALES is only desktop, currently it has two locales which should be deleted, my and oc.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Pascal Chevrel:pascalc from comment #2)
> SUPPORTED_AURORA_LOCALES is only desktop, currently it has two locales which
> should be deleted, my and oc.

Agreed on my and oc, but we're missing a bunch of locales with aurora builds even if it's only desktop.

Missing locales:
cak
gn
ja-JP-mac
ltg
ne-NP
ur

Extra locales:
my
oc

Comment 4

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Attachment: Patch on GitHub

Comment 5

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

The PR includes fixes for  the missing and extra locales.

Comment 6

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

done