1288758 - Assertion failure: !sUser32BeforeBlocklist, at [snip]mozilla/mozglue/build/WindowsDllBlocklist.cpp:769 (Port bug 1285356 to TB, IM, SM)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Local debug builds don't start due to an assertion in WindowsDllBlocklist.cpp.
I can't see it in DXR, so it must be brand new (it is, see below):

First seen 2016-07-22:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=c5465a63afb3302b8272046adfe01e0109222e91

https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedJob=42534

This comes from here:
http://hg.mozilla.org/mozilla-central/log/tip/mozglue/build/WindowsDllBlocklist.cpp

Bug 1285356.

Aaron: TB doesn't start any more in debug mode due to the MOZ_ASSERT you added here:
http://hg.mozilla.org/mozilla-central/rev/4d06c9ff66cf#l6.39

Is that intentional ;-)

Comment 1

[Jorg K (CEST = GMT+2)]

Closer looking at http://hg.mozilla.org/mozilla-central/rev/4d06c9ff66cf it looks like TB needs to port a bit of that, for example:

+    DELAYLOAD_DLLS += [
+        'winmm.dll',
+        'user32.dll',
+    ]
+

or even the changes in main().

Aleth, would that be right?

Comment 2

[aleth [:aleth]]

Yes, that's correct. The changes to browser/app/nsBrowserApp.cpp also need to be ported to the mail/app equivalent. Ditto for suite and im...

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: See whether this works.

As far as I can see, no changes are required in
mail/app/nsMailApp.cpp
suite/app/nsSuiteApp.cpp
im/app/nsMain.cpp
since

#ifdef HAS_DLL_BLOCKLIST
  DllBlocklist_Initialize();

#ifdef DEBUG
  // In order to be effective against AppInit DLLs, the blocklist must be
  // initialized before user32.dll is loaded into the process (bug 932100).
  if (GetModuleHandleA("user32.dll")) {
    fprintf(stderr, "DLL blocklist was unable to intercept AppInit DLLs.\n");
  }
#endif
#endif

is already at the top of main(). But I could be wrong ;-)

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8774226 [details] [diff] [review]
See whether this works.

With this patch applied, my local build starts up again. Let's see on try:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=75bb09056db2

Comment 5

[aleth [:aleth]]

Comment on attachment 8774226 [details] [diff] [review]
See whether this works.

Review of attachment 8774226 [details] [diff] [review]:
-----------------------------------------------------------------

You are right, but that's a sign that we have missed some bug(s) touching that file which need porting ;)

Comment 6

[Jorg K (CEST = GMT+2)]

Landed:
https://hg.mozilla.org/comm-central/rev/38e7151af632

Sadly the try run results were orange. However, that seem to have been other failures, the 
  Assertion failure: !sUser32BeforeBlocklist
have all gone. I also checked that all 1141 Mozmill tests worked on Windows XP debug.

(In reply to aleth [:aleth] from comment #5)
> You are right, but that's a sign that we have missed some bug(s) touching
> that file which need porting ;)
Well, look at the difference here:
http://hg.mozilla.org/mozilla-central/rev/4d06c9ff66cf#l2.26
We don't have the sandbox stuff. The block of code mentioned in comment #3 moved from after this block we don't have to before it. Since we don't have the block, we didn't need to move anything.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8774226 [details] [diff] [review]
See whether this works.

This needs uplift since bug 1285356 got uplifted.

Comment 8

[Jorg K (CEST = GMT+2)]

Aurora (TB 49):
https://hg.mozilla.org/releases/comm-aurora/rev/8cd47fef0b2e