Closed
Bug 1288777
Opened 9 years ago
Closed 9 years ago
MozReview Reskin - Meta Data bumps commits table.
Categories
(MozReview Graveyard :: Review Board: User Interface, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davidwalsh, Assigned: davidwalsh)
References
Details
Attachments
(1 file)
Right now the right side meta data is pushing the commits table down if the content is too long.
| Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/66508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66508/
| Assignee | ||
Comment 2•9 years ago
|
||
https://reviewboard.mozilla.org/r/66508/#review63218
The problem ocurred because the `author` field on the right can push the width of the right column. There's math in place with JavaScript to set max-widths but I don't want to fiddle with that right now -- I'd rather just put the original padding back and focus on a page redesign to avoid this issue later.
Updated•9 years ago
|
Attachment #8773847 -
Flags: review+
Comment 3•9 years ago
|
||
Comment on attachment 8773847 [details]
MozReview: Prevent commits table from being bumped by meta info. (Bug 1288777)
https://reviewboard.mozilla.org/r/66508/#review63838
| Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8773847 [details]
MozReview: Prevent commits table from being bumped by meta info. (Bug 1288777)
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66508/diff/1-2/
Attachment #8773847 -
Attachment description: MozReview: Prevent commits table from being bumped by meta info. (Bug 1288777) s?mcote → MozReview: Prevent commits table from being bumped by meta info. (Bug 1288777)
Attachment #8773847 -
Flags: review+ → review?(glob)
Comment on attachment 8773847 [details]
MozReview: Prevent commits table from being bumped by meta info. (Bug 1288777)
https://reviewboard.mozilla.org/r/66508/#review63876
Attachment #8773847 -
Flags: review?(glob) → review+
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1edc86731d0f
MozReview: Prevent commits table from being bumped by meta info. r=glob,mcote
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Assignee: nobody → dwalsh
You need to log in
before you can comment on or make changes to this bug.
Description
•