Closed
Bug 1288795
Opened 8 years ago
Closed 8 years ago
remove dead assignments in test_emitter.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
6.30 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
Prevailing style in the file for when read_topsrcdir is being tested for exception-throwingness is to omit the assignment, so let's make everything consistent.
|
Assignee | |
Comment 1•8 years ago
|
||
This style got mentioned in bug 1231764 comment 67 as being bogus, so we might as well clean up the rest of the file.
Attachment #8773868 -
Flags: review?(cmanchester)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8773868 [details] [diff] [review] remove dead assignments in test_emitter.py Review of attachment 8773868 [details] [diff] [review]: ----------------------------------------------------------------- Nice. Thanks for the patch.
Attachment #8773868 -
Flags: review?(cmanchester) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/df0a5c25f8ab remove dead assignments in test_emitter.py; r=chmanchester
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/df0a5c25f8ab
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•