1288802 - Misplaced down arrow, in select initiave dropbox

Status: RESOLVED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Trishul]

Attachment: Screenshot from 2016-07-22 23:34:03.png

Steps to reproduce:
1. Create an event 
2. Move to select an initiative box.
3. Observe the arrow.

(Observe screenshot)

Comment 1

[Tasos Katsoulas [:tasos]]

The direction of the arrow signifies that there is a drop-down menu where the user can select something from a variety of choices. This probably is not a bug thus marking it as invalid. Please reopen it if this is not the case. Thanks!

Comment 2

[Trishul]

I think I should be more clear with the issue.
The problem is not the black arrow, but the grey star overlapping .
Kindly observe again.(the grey star)

The grey star with class "required-field"

Comment 3

[Tasos Katsoulas [:tasos]]

Thanks Trishul! I am adding a needinfo here for Nikos.

Comment 4

[Nikos Roussos [:comzeradd]]

Yes, the "problem" is the required field pictogram star is not placed properly for this field. Same issue exists on the "Estimated Attendance" field.
It's probably better to place the pictogram as part of the label in these fields.

Comment 5

[Sammy Ahad]

can you assign this bug to me, i'm looking into this. Where should I start when trying to replicate this bug. Ive read the above mentioned steps 

Steps to reproduce:
1. Create an event 
2. Move to select an initiative box.
3. Observe the arrow.

(Observe screenshot)

But this seems pretty vague

Comment 6

[Nikos Roussos [:comzeradd]]

Hey Sammy,

See #comment4. The problem is actual the star icon (displayed on required fields) that overlaps with the standard dropdown arrow. I thin the screenshot shows the problem.

Comment 7

[anejaalisha]

If nobody is working on this bug, can I take it up?

Comment 8

[Henrik Mitsch [:hmitsch]]

Hi anejaalisha,

yes, please feel free to take this bug.
I hope it is okay if I assign it to you?

Best regards,
   Henrik

Comment 9

[anejaalisha]

As I am not a Mozilla Rep,I am not able to create an event, hence, I am not able to replicate the problem. Any solution to this?

Comment 10

[Tasos Katsoulas [:tasos]]

Hi anejaalisha,

You can consult the documentation [0] in order to setup and run the ReMo portal locally on your computer. If you need any additional help, don't hesitate to ask in irc [1] in the #remo-dev channel.

Best,
Tasos

[0] https://remo.readthedocs.io/en/latest/
[1] https://wiki.mozilla.org/IRC

Comment 11

[anejaalisha]

(In reply to Tasos Katsoulas [:tasos] from comment #10)
> Hi anejaalisha,
> 
> You can consult the documentation [0] in order to setup and run the ReMo
> portal locally on your computer. If you need any additional help, don't
> hesitate to ask in irc [1] in the #remo-dev channel.
> 
> Best,
> Tasos
> 
> [0] https://remo.readthedocs.io/en/latest/
> [1] https://wiki.mozilla.org/IRC

Thanks! I will do as suggested.

Comment 12

[anejaalisha]

 Hi. I am trying to setup remo locally. However,when i run this command - sudo docker-compose run web python manage.py update_product_details -f ; i get this error :  Service 'celery' failed to build: The command '/bin/sh -c pip install --require-hashes --no-deps -r requirements/dev.txt' returned a non-zero code: 2. 

How can I fix this?

Comment 13

[anejaalisha]

How do I login when a new user is created because it says : ImproperlyConfigured at /oidc/authenticate/
Setting OIDC_OP_AUTHORIZATION_ENDPOINT not found ?

Comment 14

[Rachel]

Attachment: proposed layout v1

Hi, will it be possible be assigned this bug?

I have drafted a fix and will appreciate feedback if the modified layout is okay. Screenshots from the fix are attached. 

Code Changes :

https://github.com/tsmrachel/remo/commit/3a543b6b06b249e9c92ab8af34e6ca980b21ccbc

Comment 15

[Michael Kohler [:mkohler]]

Thanks, the screenshots look good to me.

For the code, I think the best way would be to create a PR, so we can do a normal code review.

Comment 16

[Rachel]

https://github.com/mozilla/remo/pull/1314(In reply to Michael Kohler [:mkohler] from comment #15)
> Thanks, the screenshots look good to me.
> 
> For the code, I think the best way would be to create a PR, so we can do a
> normal code review.

PR : https://github.com/mozilla/remo/pull/1314

Comment 17

[[github robot]]

Commit pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/0564c4b25cd0b08a1f42b55c54305f3918896415
[fix bug 1288802] Misplaced down arrow, in select initiave dropbox (#1314)

* [fix bug 1288802] Misplaced down arrow, in select initiave dropbox

* adjusted required-field spacing

* removed extra line

* set .required-field - top: 18px, .required-field-input - top: 20px