1288823 - Various XPConnect cleanups

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

I came across some unused functions, plus a few other things, while digging through xpcprivate.h.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Use doSweep more consistently in XPCJSRuntime::FinalizeCallback.

There's a bunch of patches, but there's nothing fancy going on.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fdb87155d07

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Remove unused #defines from xpcprivate.h.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Mark more classes final in xpcprivate.h.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Mark things delete in XPConnect.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 5 - Remove the unused XPCWrappedNativeProto::mClassInfoFlags.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: part 6 - Remove unused methods from XPCNativeScriptableInfo and XPCWrappedNativeProto.

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: part 7 - Fix XPCNativeScriptableInfo ctor arguments.

This ctor is only called in one place, with one argument.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76dd054b8a00
part 1 - Use doSweep more consistently in XPCJSRuntime::FinalizeCallback. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1b7128fc7b
part 2 - Remove unused #defines from xpcprivate.h. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/16f9e46e63bf
part 3 - Mark more classes final in xpcprivate.h. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/6485be343d0c
part 4 - Mark things delete in XPConnect. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/db8960bd95ac
part 5 - Remove the unused XPCWrappedNativeProto::mClassInfoFlags. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c20c62cfabd
part 6 - Remove unused methods from XPCNativeScriptableInfo and XPCWrappedNativeProto. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/51d3deee1f32
part 7 - Fix XPCNativeScriptableInfo ctor arguments. r=mrbkap

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76dd054b8a00
https://hg.mozilla.org/mozilla-central/rev/9b1b7128fc7b
https://hg.mozilla.org/mozilla-central/rev/16f9e46e63bf
https://hg.mozilla.org/mozilla-central/rev/6485be343d0c
https://hg.mozilla.org/mozilla-central/rev/db8960bd95ac
https://hg.mozilla.org/mozilla-central/rev/8c20c62cfabd
https://hg.mozilla.org/mozilla-central/rev/51d3deee1f32