Closed Bug 1288823 Opened 4 years ago Closed 4 years ago

Various XPConnect cleanups

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(7 files)

I came across some unused functions, plus a few other things, while digging through xpcprivate.h.
There's a bunch of patches, but there's nothing fancy going on.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fdb87155d07
Attachment #8774053 - Flags: review?(mrbkap)
This ctor is only called in one place, with one argument.
Attachment #8774059 - Flags: review?(mrbkap)
Attachment #8774053 - Flags: review?(mrbkap) → review+
Attachment #8774054 - Flags: review?(mrbkap) → review+
Attachment #8774055 - Flags: review?(mrbkap) → review+
Attachment #8774056 - Flags: review?(mrbkap) → review+
Attachment #8774057 - Flags: review?(mrbkap) → review+
Attachment #8774058 - Flags: review?(mrbkap) → review+
Attachment #8774059 - Flags: review?(mrbkap) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76dd054b8a00
part 1 - Use doSweep more consistently in XPCJSRuntime::FinalizeCallback. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1b7128fc7b
part 2 - Remove unused #defines from xpcprivate.h. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/16f9e46e63bf
part 3 - Mark more classes final in xpcprivate.h. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/6485be343d0c
part 4 - Mark things delete in XPConnect. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/db8960bd95ac
part 5 - Remove the unused XPCWrappedNativeProto::mClassInfoFlags. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c20c62cfabd
part 6 - Remove unused methods from XPCNativeScriptableInfo and XPCWrappedNativeProto. r=mrbkap
https://hg.mozilla.org/integration/mozilla-inbound/rev/51d3deee1f32
part 7 - Fix XPCNativeScriptableInfo ctor arguments. r=mrbkap
You need to log in before you can comment on or make changes to this bug.