1288825 - toolkit/components/url-classifier/nsUrlClassifierUtils.cpp:94:4: error: Unrecognized platform type.

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Jan Beich]

Bug 1275507 broke build on Tier3 Unix-like systems: BSD (DragonFly, FreeBSD, NetBSD, OpenBSD), Solaris (Illumos, SmartOS, etc). Since many of those can emulate Linux ABI it may make sense to fake LINUX_PLATFORM. However, a similar case can be made against Wine being able to run some Windows malware.

$ ./mach build
[...]
In file included from objdir/toolkit/components/url-classifier/Unified_cpp_url-classifier0.cpp:65:
toolkit/components/url-classifier/nsUrlClassifierUtils.cpp:94:4: error: Unrecognized platform type.
  #error Unrecognized platform type.
   ^
1 error generated.

http://buildbot.rhaalovely.net/builders/mozilla-central-freebsd-amd64/builds/907/steps/build/logs/stdio
http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/1798/steps/build/logs/stdio

Comment 1

[Jan Beich]

Attachment: Bug 1288825 - Unbreak build on Unix after bug 1275507.

Review commit: https://reviewboard.mozilla.org/r/66560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66560/

Comment 2

[François Marier [:francois]]

Comment on attachment 8773926 [details]
Bug 1288825 - Unbreak build on Unix after bug 1275507.

https://reviewboard.mozilla.org/r/66560/#review63282

I'd rather have non-Linux platforms return PLATFORM_TYPE_UNSPECIFIED instead:

https://dxr.mozilla.org/mozilla-central/rev/4c05938a64a7fde3ac2d7f4493aee1c5f2ad8a0a/toolkit/components/url-classifier/chromium/safebrowsing.proto#275

Comment 3

[Jan Beich]

Comment on attachment 8773926 [details]
Bug 1288825 - Unbreak build on Unix after bug 1275507.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66560/diff/1-2/

Comment 4

[François Marier [:francois]]

Comment on attachment 8773926 [details]
Bug 1288825 - Unbreak build on Unix after bug 1275507.

https://reviewboard.mozilla.org/r/66560/#review63292

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bda9fd505371
Unbreak build on Unix after bug 1275507. r=francois

Comment 6

[Henry Chang [:hchang]]

Sorry it's my fault :( 

Thanks Jan for fixing this and Francois doing the review!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bda9fd505371

Comment 8

[Jan Beich]

(In reply to François Marier [:francois] from comment #2)
> I'd rather have non-Linux platforms return PLATFORM_TYPE_UNSPECIFIED instead:

Hmm, http://testsafebrowsing.appspot.com/s/phishing.html matches SOCIAL_ENGINEERING for any threatType *except* PLATFORM_TYPE_UNSPECIFIED. Reminds me of Google Maps where BSD users are forced to Lite mode even with working WebGL.

Comment 9

[François Marier [:francois]]

(In reply to Jan Beich from comment #8)
> (In reply to François Marier [:francois] from comment #2)
> > I'd rather have non-Linux platforms return PLATFORM_TYPE_UNSPECIFIED instead:
> 
> Hmm, http://testsafebrowsing.appspot.com/s/phishing.html matches
> SOCIAL_ENGINEERING for any threatType *except* PLATFORM_TYPE_UNSPECIFIED.

I filed bug 1362501 for this issue.