Closed Bug 1288829 Opened 5 years ago Closed 5 years ago

Early return from bad bracket in CompositorOGL.cpp#l355

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: BenWa, Unassigned)

References

Details

Attachments

(1 file)

rhunt: so I keep getting a compiler warning for misleading indents on this line of code here
rhunt: http://hg.mozilla.org/mozilla-central/file/e0bc88708ffe/gfx/layers/opengl/CompositorOGL.cpp#l355

Looks like the initial code skipped the {} brackets and bug 1002846 introduced the error.
If you can fix this ASAP it would be nice. This might be leading to supported users getting blacklisted.
Flags: needinfo?(eyim)
Comment on attachment 8773938 [details]
Bug 1288829 - Early return from bad bracket in CompositorOGL.cpp#l355

https://reviewboard.mozilla.org/r/66564/#review63288
Attachment #8773938 - Flags: review?(bgirard) → review+
Pushed by b56girard@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a91ecd644f30
Early return from bad bracket in CompositorOGL.cpp#l355 r=BenWa
https://hg.mozilla.org/mozilla-central/rev/a91ecd644f30
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Flags: needinfo?(eyim)
You need to log in before you can comment on or make changes to this bug.