1288838 - Convert telemetry events to native methods

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Convert telemetry events in GeckoEvent to native method calls in Telemetry.java.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add telemetry native methods to Android telemetry module (v1)

Add and use native method calls in Telemetry.java to replace the
telemetry events in GeckoEvent.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Update auto-generated bindings (v1)

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove telemetry events from GeckoEvent (v1)

Remove the now-obsolete telemetry events from GeckoEvent.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8775191 [details] [diff] [review]
Add telemetry native methods to Android telemetry module (v1)

Review of attachment 8775191 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/Telemetry.h
@@ +14,5 @@
> +
> +namespace mozilla {
> +namespace widget {
> +
> +class Telemetry final

This is a lot of code in a header, but maybe not as bad an offender as previous native helper classes :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/9a90e9fe5bf1
Add telemetry native methods to Android telemetry module; r=snorp
https://hg.mozilla.org/integration/fx-team/rev/d404ad0723c0
Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/fx-team/rev/388d4af4b1b1
Remove telemetry events from GeckoEvent; r=snorp

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/2d03d12d868b
Follow-up to fix checkstyle error; r=me

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a90e9fe5bf1
https://hg.mozilla.org/mozilla-central/rev/d404ad0723c0
https://hg.mozilla.org/mozilla-central/rev/388d4af4b1b1
https://hg.mozilla.org/mozilla-central/rev/2d03d12d868b