Closed Bug 1288838 Opened 5 years ago Closed 5 years ago

Convert telemetry events to native methods

Categories

(Core :: Widget: Android, defect, P3)

All
Android
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(3 files)

Convert telemetry events in GeckoEvent to native method calls in Telemetry.java.
Add and use native method calls in Telemetry.java to replace the
telemetry events in GeckoEvent.
Attachment #8775191 - Flags: review?(snorp)
Remove the now-obsolete telemetry events from GeckoEvent.
Attachment #8775193 - Flags: review?(snorp)
Comment on attachment 8775191 [details] [diff] [review]
Add telemetry native methods to Android telemetry module (v1)

Review of attachment 8775191 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/Telemetry.h
@@ +14,5 @@
> +
> +namespace mozilla {
> +namespace widget {
> +
> +class Telemetry final

This is a lot of code in a header, but maybe not as bad an offender as previous native helper classes :)
Attachment #8775191 - Flags: review?(snorp) → review+
Attachment #8775193 - Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/9a90e9fe5bf1
Add telemetry native methods to Android telemetry module; r=snorp
https://hg.mozilla.org/integration/fx-team/rev/d404ad0723c0
Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/fx-team/rev/388d4af4b1b1
Remove telemetry events from GeckoEvent; r=snorp
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/2d03d12d868b
Follow-up to fix checkstyle error; r=me
You need to log in before you can comment on or make changes to this bug.