1288846 - Inspector panel blank after refreshing page on aframe.io

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect, P2)

Description

[James Long (:jlongster)]

STR:

1. Go to https://aframe.io/
2. Inspect the canvas element (the "A" and the sky)
3. See the `a-sky` and other sibling elements of the canvas
4. Delete `a-sky` (right click -> delete)
5. Refresh the page

The inspector panel is blank.

Comment 1

[Julian Descottes [:jdescottes]]

We get the following stack trace when reloading the page:

getTopWindow@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/layout/utils.js:33:18|
isTopWindow@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/layout/utils.js:58:35|
getFrameElement@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/layout/utils.js:121:3|
WalkerActor<._childOfWindow@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/inspector.js:2394:13|
WalkerActor<.onFrameUnload@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/inspector.js:2407:11|
[...]
_willNavigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/webbrowser.js:1962:5|

Looks like onFrameUnload, the inspector actor tries to release all orphan nodes and this fails when one of the orphan nodes is a Custom Element.

Inspector bug triage, filter on CLIMBING SHOES.

Comment 2

[Alexandre Poirot [:ochameau]]

I wasn't able to reproduce this bug on nightly. May this bug be fixed by one of my patches to get rid of blank inspectors? I haven't fixed anything regarding any issues with Custom element, but I possibly changed the behavior of onFrameLoad and onFrameUnload

Comment 3

[Patrick Brosset <:pbro>]

This now works ok.