1288849 - Windows configuration build-spew includes "grep: invalid option -- /"

Status: RESOLVED DUPLICATE of bug 1334268

(Firefox Build System :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Start a clobber build on Windows.
 2. Watch the first bit of configuration output (particularly watch for "checking for 64-bit OS")

ACTUAL RESULTS:
The point includes:
 0:15.90 checking for 64-bit OS... no
 0:16.51 grep: invalid option -- /
 0:16.51 Usage: grep [OPTION]... PATTERN [FILE]...
 0:16.51 Try `grep --help' for more information.
 0:16.55 grep: invalid option -- /
 0:16.55 Usage: grep [OPTION]... PATTERN [FILE]...
 0:16.55 Try `grep --help' for more information.
 0:17.06 checking for valid debug flags... yes

EXPECTED RESULTS:
No such grep errors. We should invoke grep in a way that the system (mingw in this case I guess?) understands.

Comment 1

[Daniel Holbert [:dholbert]]

(My mozillabuild is from March 29th 2016, if it matters (based on the datestamp on the installer that I used). Not sure what version that corresponds to.)

Comment 2

[Mike Hommey [:glandium]]

There are way more errors in configure logs on Windows. They will go away as we move things to python configure. I'm not convinced it's worth specifically chasing them before that happens.

Comment 3

[Daniel Holbert [:dholbert]]

Fair enough. I won't hold my breath here, then. :)

Comment 4

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

This is due to the quoting mechanism used in autoconf (ref http://autogen.sourceforge.net/acquoting.html).

These lines from bug 1271794
https://dxr.mozilla.org/mozilla-central/rev/96cb95af530477edb66ae48d98c18533476e57bb/old-configure.in#995,998
are intending to output "grep -i [-/]arch:" but the brackets are quotes and it becomes "grep -i -/arch:"
The same issue is present in js/src/old-configure.in.

This could be fixed with double quoting as on
https://dxr.mozilla.org/mozilla-central/rev/96cb95af530477edb66ae48d98c18533476e57bb/old-configure.in#93
(or with changequote as on line 230, or quadrigraphs)

However I don't know if fixing it would break something else. This test currently will always be true and thus -arch:SSE2 is always added rather than deferring to a preexisting arch switch.

Comment 6

[Daniel Holbert [:dholbert]]

Thanks for closing the loop. I'm glad this was fixed!