Closed Bug 1288860 Opened 3 years ago Closed 3 years ago

Use CompositorWidget instead of nsIWidget in GLContextProvider

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

Details

Attachments

(1 file)

Update the GLContextProvider interface to take a CompositorWidget instead of nsIWidget. For now they will just use widget->RealWidget(), but eventually they can be updated to support out of process compositing on a per platform basis.

This allows OGLCompositor to remove its dependency on RealWidget().
There are other dependencies on CreateForWindow besides Compositors, and so instead I've added a CreateForCompositorWidget method to GLContextProvider. Currently this just dispatchs to CreateForWindow, and uses RealWidget() on all platforms. But this will allow us to remove dependencies on RealWidget() for some platforms, such as when we use X11 and GLX.
Attachment #8774505 - Flags: review?(jmuizelaar)
Attachment #8774505 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a34d250bea8e
Change GLContextProvider to use CompositorWidget. r=jrmuizel
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a34d250bea8e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.