Closed Bug 1288924 Opened 3 years ago Closed 3 years ago

Remove __func__ polyfill for VS2013

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Now that we've dropped support for VS2013 (bug 1186064), we can use VS2015's __func__ instead of our polyfill.
Attachment #8774071 - Flags: review?(nfroyd)
Comment on attachment 8774071 [details] [diff] [review]
remove-__func__-polyfill.patch

Review of attachment 8774071 [details] [diff] [review]:
-----------------------------------------------------------------

Want to take care of http://dxr.mozilla.org/mozilla-central/source/media/libcubeb/tests/test_sanity.cpp#21 while you're at it?
Attachment #8774071 - Flags: review?(nfroyd) → review+
Thanks for the speedy review, Nathan!

(In reply to Nathan Froyd [:froydnj] from comment #1)
> Want to take care of
> http://dxr.mozilla.org/mozilla-central/source/media/libcubeb/tests/
> test_sanity.cpp#21 while you're at it?

@ kinetik: mozilla-central no longer supports VS2013. Since you maintain cubeb as an external library, do you wish to maintain VS2013 support for other applications that may use cubeb?

https://github.com/kinetiknz/cubeb/blob/master/test/test_sanity.cpp#L21
Flags: needinfo?(kinetik)
(In reply to Chris Peterson [:cpeterson] from comment #2)
> @ kinetik: mozilla-central no longer supports VS2013. Since you maintain
> cubeb as an external library, do you wish to maintain VS2013 support for
> other applications that may use cubeb?
> 
> https://github.com/kinetiknz/cubeb/blob/master/test/test_sanity.cpp#L21

Nope, so I've killed this upstream in https://github.com/kinetiknz/cubeb/commit/a966fafbf7f95c6d516b444f15eed1648c8e6dc8
Flags: needinfo?(kinetik)
(In reply to Matthew Gregan [:kinetik] from comment #3)
> Nope, so I've killed this upstream in
> https://github.com/kinetiknz/cubeb/commit/
> a966fafbf7f95c6d516b444f15eed1648c8e6dc8

Thanks!
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/19920a6cf0f8
Remove __func__ polyfill for VS2013. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/19920a6cf0f8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.