1288969 - Remove pref migration code from calProviderUtils

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect, P5)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(From bug 1280898 comment #300)
> https://reviewboard.mozilla.org/r/63116/#review63340
> 
> ::: calendar/base/modules/calProviderUtils.jsm:539
> (Diff revision 2)
> >                  }
> >              }
> >          }
> >  
> > -        let this_ = this;
> > -        function takeOverIfNotPresent(oldPref, newPref, dontDeleteOldPref) {
> > +        let takeOverIfNotPresent = (oldPref, newPref, dontDeleteOldPref) => {
> > +            let val = calMgr.getCalendarPref_(this, oldPref);
> 
> With respect to dxr, takeOverIfNotPresent is only called without
> dontDeleteOldPref, so we should have migrated the prefs already since that
> was implemented. So it should be save to get rid of that old migration code
> now.

Comment 1

[Hemant Singh Patwal]

Hi,

I have never contributed to Calendar.

Working on this bug would give me a deeper understanding of Mozilla calendar code base. I have a fair grasp of JS.
Please, guide me on how to start.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Hi Hemant, thank you for your interest in calendaring! This bug is really trivial, you just need to get rid of the migration code at https://dxr.mozilla.org/comm-central/source/calendar/base/modules/calProviderUtils.jsm#535

The pref lightning-main-in-composite and the other old pref are not being used anymore. You should also search dxr to see if these pref names are mentioned in other places in the calendar codebase and remove them there also.

If you want to find out how to set up a build environment, please check out https://developer.mozilla.org/en-US/docs/Simple_Thunderbird_build

You can find me on irc.mozilla.org in the channel #calendar if you have questions.

Comment 3

[Hemant Singh Patwal]

Thanks for assigning it to me .

Unfortunately, I can proceed only after 15 July,as I am out.I  will continue after 15.
Extremely sorry, for inconvenience.

Comment 4

[Hemant Singh Patwal]

After fixing python issue ,still build terminates with following log:

34:24.66 c:\thunderbird-src\comm-central\mailnews\addrbook\src\nsAbWinHelper.h(9): fatal error C1083: Cannot open include file: 'mapix.h': No such file or directory
34:24.66 mozmake.EXE[4]: *** [c:/thunderbird-src/comm-central/mozilla/config/rules.mk:1052: nsAbOutlookDirFactory.obj] Error 2
34:24.67 mozmake.EXE[3]: *** [c:/thunderbird-src/comm-central/mozilla/config/recurse.mk:73: mailnews/addrbook/src/target] Error 2
34:24.67 mozmake.EXE[3]: *** Waiting for unfinished jobs....
34:25.22 cl : Command line warning D9025 : overriding '/arch:SSE2' with '/arch:AVX2'
34:25.22 error_intrin_avx2.c
34:25.22 c:\thunderbird-src\comm-central\mozilla\third_party\aom\av1/common/odintrin.h(18): warning C4005: '_USE_MATH_DEFINES': macro redefinition
34:25.22 c:/Users/HP/mozilla/comm-central/objdir-tb/mozilla-config.h(142): note: see previous definition of '_USE_MATH_DEFINES'
34:25.36 nsMsgFolderCacheElement.cpp
34:25.49 nsMsgCompressOStream.cpp
34:25.98 highbd_block_error_intrin_sse2.c
34:28.78 nsMsgFolderCompactor.cpp
34:29.65 nsMsgFolderDataSource.cpp
34:30.76 nsMsgDBFolder.cpp
34:31.11 nsMsgFileStream.cpp
34:33.15 nsMsgFolderNotificationService.cpp
34:34.84 nsMsgI18N.cpp
34:36.47 nsMsgGroupThread.cpp
34:38.01 nsMsgIdentity.cpp
34:40.08 nsMsgGroupView.cpp
34:42.12 nsMsgIncomingServer.cpp
34:44.18 nsMsgKeyArray.cpp
34:45.20 nsMsgMailSession.cpp
34:46.43 nsMsgKeySet.cpp
34:47.74 nsMsgOfflineManager.cpp
34:49.33 nsMsgLineBuffer.cpp
34:52.85 nsMsgPrintEngine.cpp
34:52.87 nsMsgMailNewsUrl.cpp
34:55.99 nsMsgProgress.cpp
34:56.42 nsMsgProtocol.cpp
34:58.99 nsMsgReadStateTxn.cpp
34:59.77 nsMsgPurgeService.cpp
35:01.72 nsMsgTxn.cpp
35:03.21 nsMsgQuickSearchDBView.cpp
35:05.76 nsMsgUtils.cpp
35:06.44 nsMsgRDFDataSource.cpp
35:07.54 nsStopwatch.cpp
35:07.55 msgbsutl_s.lib.desc
35:08.63 nsMsgRDFUtils.cpp
35:12.97 nsMsgSearchDBView.cpp
35:16.00 nsMsgServiceProvider.cpp
35:18.85 nsMsgSpecialViews.cpp
35:23.05 nsMsgStatusFeedback.cpp
35:26.42 nsMsgTagService.cpp
35:29.28 nsMsgThreadedDBView.cpp
35:32.91 nsMsgWindow.cpp
35:35.74 nsMsgXFViewThread.cpp
35:39.38 nsMsgXFVirtualFolderDBView.cpp
35:43.24 nsSpamSettings.cpp
35:47.01 nsStatusBarBiffManager.cpp
35:50.82 nsSubscribableServer.cpp
35:53.99 cl : Command line warning D9025 : overriding '/arch:SSE2' with '/arch:AVX2'
35:53.99 hybrid_fwd_txfm_avx2.c
35:53.99 c:\thunderbird-src\comm-central\mozilla\third_party\aom\av1/common/odintrin.h(18): warning C4005: '_USE_MATH_DEFINES': macro redefinition
35:53.99 c:/Users/HP/mozilla/comm-central/objdir-tb/mozilla-config.h(142): note: see previous definition of '_USE_MATH_DEFINES'
35:54.32 nsSubscribeDataSource.cpp
35:54.34 mailnews_base_src.lib.desc
35:54.98 wedge_utils_sse2.c
35:54.98 c:\thunderbird-src\comm-central\mozilla\third_party\aom\av1/common/odintrin.h(18): warning C4005: '_USE_MATH_DEFINES': macro redefinition
35:54.98 c:/Users/HP/mozilla/comm-central/objdir-tb/mozilla-config.h(142): note: see previous definition of '_USE_MATH_DEFINES'
35:55.00 fast.c
35:55.46 nonmax.c
35:57.73 fast_9.c
37:34.91 dct_intrin_sse2.c
37:34.91 c:\thunderbird-src\comm-central\mozilla\third_party\aom\av1/common/odintrin.h(18): warning C4005: '_USE_MATH_DEFINES': macro redefinition
37:34.91 c:/Users/HP/mozilla/comm-central/objdir-tb/mozilla-config.h(142): note: see previous definition of '_USE_MATH_DEFINES'
39:39.92 highbd_fwd_txfm_sse4.c
39:39.92 c:\thunderbird-src\comm-central\mozilla\third_party\aom\av1/common/odintrin.h(18): warning C4005: '_USE_MATH_DEFINES': macro redefinition
39:39.92 c:/Users/HP/mozilla/comm-central/objdir-tb/mozilla-config.h(142): note: see previous definition of '_USE_MATH_DEFINES'
39:39.92 media_libaom.lib.desc
39:40.18 mozmake.EXE[2]: *** [c:/thunderbird-src/comm-central/mozilla/config/recurse.mk:33: compile] Error 2
39:40.18 mozmake.EXE[1]: *** [c:/thunderbird-src/comm-central/mozilla/config/rules.mk:453: default] Error 2
39:40.18 mozmake.EXE: *** [client.mk:397: build] Error 2
39:40.26 37 compiler warnings present.
2

Comment 5

[Richard Marti (:Paenglab)]

Have you installed the MAPI headers? See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites#Required_Tools how and where to installe them.

Comment 6

[Hemant Singh Patwal]

(In reply to Richard Marti (:Paenglab) from comment #5)
> Have you installed the MAPI headers? See
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Windows_Prerequisites#Required_Tools how and where to
> installe them.

Thanks Richard, build is successful now.But on running |./mozilla/mach run| it says "Your Thunderbird profile cannot be loaded. It may be missing or inaccessible."

Comment 7

[Richard Marti (:Paenglab)]

Never tried mach run. You can also start it in the console with "path/to/your/objdir/thunderbird.exe -p" If you have already a TB session running you can add -no-remote.

Comment 8

[Hemant Singh Patwal]

(In reply to Richard Marti (:Paenglab) from comment #7)
> Never tried mach run. You can also start it in the console with
> "path/to/your/objdir/thunderbird.exe -p" If you have already a TB session
> running you can add -no-remote.

I tried that way but the same dialogue box pops up.
Here is what I tried:

HP@hemant /c/thunderbird-src/comm-central
$ ./mozilla/mach run
 0:00.63 /Users/HP/mozilla/comm-central/objdir-tb\dist\bin\thunderbird.exe -no-remote -profile /Users/HP/mozilla/comm-central/objdir-tb\tmp\scratch_user

If we install thunderbird from https://www.mozilla.org/en-US/thunderbird/ the profile directory is in ../Users/../AppData/Roaming/
folder and can be fixed easily, if there are profile issues.
But here I do not know where exactly profile directory is located for the build.Sorry ,if I am wrong here.

Comment 9

[Richard Marti (:Paenglab)]

Try only /Users/HP/mozilla/comm-central/objdir-tb\dist\bin\thunderbird.exe -no-remote -p . Then the profile manager should appear and you can select or create a profile. Or you can also doublec lick thunderbird.exe through Explorer and it opens the same profile as the installed TB.

Comment 10

[Hemant Singh Patwal]

Attachment: Bug 1288969 - Remove pref migration code from calProviderUtils.

Review commit: https://reviewboard.mozilla.org/r/163016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163016/

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8892007 [details]
Bug 1288969 - Remove pref migration code from calProviderUtils.

https://reviewboard.mozilla.org/r/163016/#review192544

Just removing the function is obviously not enough, you also need to remove all callers.

Comment 12

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

As this bug seems to be dormant, I attached a complete patch.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b66c0faca0df
Remove pref migration code from calProviderUtils. r=philipp