Closed Bug 1288984 Opened 3 years ago Closed 3 years ago

DragonFly fails to find X11 headers during build

Categories

(Firefox Build System :: General, defect)

Unspecified
Other
defect
Not set

Tracking

(firefox48 wontfix, firefox49 fixed, firefox-esr45 fixed, firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox48 --- wontfix
firefox49 --- fixed
firefox-esr45 --- fixed
firefox50 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(2 files)

old-configure.in is currently sloppy with X11 flags as those were added before Xorg started doing modular releases. Also, not finding installed packages by default is an OS (mis)feature[1] that DragonFly inherited. FreeBSD workaround was added in bug 112987 and OpenBSD workaround - in bug 589088. So, let's add one more workaround.

$ ./mach build
[...]
 0:16.42 In file included from objdir/dist/include/npapi.h:47:0,
 0:16.42                  from objdir/dist/include/nsIPluginInstanceOwner.h:27,
 0:16.42                  from objdir/dist/include/nsNPAPIPluginInstance.h:14,
 0:16.42                  from accessible/base/nsAccessibilityService.cpp:90,
 0:16.42                  from objdir/accessible/base/Unified_cpp_accessible_base1.cpp:56:
 0:16.42 objdir/dist/system_wrappers/X11/Xlib.h:3:27: fatal error: X11/Xlib.h: No such file or directory
 0:16.42 compilation terminated.

[1] https://wiki.freebsd.org/WarnerLosh/UsrLocal
Martin, does NetBSD need a similar fix for for building firefox against modular Xorg from pkgsrc?
Does not look like we need it.
Comment on attachment 8774191 [details]
Bug 1288984 - Copy X11 include flags for more BSDs.

https://reviewboard.mozilla.org/r/66738/#review63930
Attachment #8774191 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5db66203614e
Copy X11 include flags for more BSDs. r=glandium
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5db66203614e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8774191 [details]
Bug 1288984 - Copy X11 include flags for more BSDs.

Approval Request Comment
[ESR consideration]: Easier debugging on Tier3 platforms by building outside of package system
[Feature/regressing bug #]: Neither
[User impact if declined]: Broken build on DragonFly unless |export CPPFLAGS=-isystem/usr/local/include| is added to .mozconfig
[Describe test coverage new/current, TreeHerder]: landed on m-c
[Risks and why]: NPOTB. Can only break build due to mismerge.
[String/UUID change made/needed]: None
Attachment #8774191 - Flags: approval-mozilla-esr45?
Attachment #8774191 - Flags: approval-mozilla-beta?
Attachment #8774191 - Flags: approval-mozilla-aurora?
Attachment #8774191 - Flags: approval-mozilla-esr45?
Attached patch esr45 versionSplinter Review
configure.in was renamed to old-configure.in per bug 1250294. This patch is same as attachment 8774191 [details] but for configure.in.

See comment 7 for "approval request comment".
Attachment #8774880 - Flags: approval-mozilla-esr45?
See Also: → 1285512
Assignee: nobody → jbeich
Comment on attachment 8774191 [details]
Bug 1288984 - Copy X11 include flags for more BSDs.

This is too late for 48 but taking it for 49
Attachment #8774191 - Flags: approval-mozilla-beta?
Attachment #8774191 - Flags: approval-mozilla-beta-
Attachment #8774191 - Flags: approval-mozilla-aurora?
Attachment #8774191 - Flags: approval-mozilla-aurora+
Comment on attachment 8774880 [details] [diff] [review]
esr45 version

Taking in in ESR to simplify your life, should be in 45.4.0.
Attachment #8774880 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.