Closed Bug 1288984 Opened 3 years ago Closed 3 years ago
Fly fails to find X11 headers during build
58 bytes, text/x-review-board-request
647 bytes, patch
|Details | Diff | Splinter Review|
old-configure.in is currently sloppy with X11 flags as those were added before Xorg started doing modular releases. Also, not finding installed packages by default is an OS (mis)feature that DragonFly inherited. FreeBSD workaround was added in bug 112987 and OpenBSD workaround - in bug 589088. So, let's add one more workaround. $ ./mach build [...] 0:16.42 In file included from objdir/dist/include/npapi.h:47:0, 0:16.42 from objdir/dist/include/nsIPluginInstanceOwner.h:27, 0:16.42 from objdir/dist/include/nsNPAPIPluginInstance.h:14, 0:16.42 from accessible/base/nsAccessibilityService.cpp:90, 0:16.42 from objdir/accessible/base/Unified_cpp_accessible_base1.cpp:56: 0:16.42 objdir/dist/system_wrappers/X11/Xlib.h:3:27: fatal error: X11/Xlib.h: No such file or directory 0:16.42 compilation terminated.  https://wiki.freebsd.org/WarnerLosh/UsrLocal
Review commit: https://reviewboard.mozilla.org/r/66738/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/66738/
Attachment #8774191 - Flags: review?(mh+mozilla)
Martin, does NetBSD need a similar fix for for building firefox against modular Xorg from pkgsrc?
Does not look like we need it.
Comment on attachment 8774191 [details] Bug 1288984 - Copy X11 include flags for more BSDs. https://reviewboard.mozilla.org/r/66738/#review63930
Attachment #8774191 - Flags: review?(mh+mozilla) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5db66203614e Copy X11 include flags for more BSDs. r=glandium
Comment on attachment 8774191 [details] Bug 1288984 - Copy X11 include flags for more BSDs. Approval Request Comment [ESR consideration]: Easier debugging on Tier3 platforms by building outside of package system [Feature/regressing bug #]: Neither [User impact if declined]: Broken build on DragonFly unless |export CPPFLAGS=-isystem/usr/local/include| is added to .mozconfig [Describe test coverage new/current, TreeHerder]: landed on m-c [Risks and why]: NPOTB. Can only break build due to mismerge. [String/UUID change made/needed]: None
configure.in was renamed to old-configure.in per bug 1250294. This patch is same as attachment 8774191 [details] but for configure.in. See comment 7 for "approval request comment".
Attachment #8774880 - Flags: approval-mozilla-esr45?
Comment on attachment 8774191 [details] Bug 1288984 - Copy X11 include flags for more BSDs. This is too late for 48 but taking it for 49
Comment on attachment 8774880 [details] [diff] [review] esr45 version Taking in in ESR to simplify your life, should be in 45.4.0.
Attachment #8774880 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
You need to log in before you can comment on or make changes to this bug.