unnecessary horizontal scrolling diff page

NEW
Unassigned

Status

MozReview
Review Board: User Interface
2 years ago
2 years ago

People

(Reporter: glob, Unassigned)

Tracking

Production

Details

(Reporter)

Description

2 years ago
when loading a diff the horizontal scrollbar is active and i can scroll the whole page left/right 15px.

STR
- ensure devtools are either disabled, or detached from the window
- load https://reviewboard.mozilla.org/r/63692/diff/1/ in a maximised window

Expected
- no horizontal scrolling


it looks like the width of the .diff-highlight element, which is calculated with javascript (wat) is initially 15px too wide.

in my case it's 1916px, however my <html> element is only 1901px wide.

<div class="diff-highlight" style="left: -19.5px; width: 1916px; top: 0px; height: 71px;"></div>

resizing the window forces a recalc, resulting in the correct width being applied to that element.

<div class="diff-highlight" style="left: -19.5px; width: 1901px; top: 0px; height: 71px;"></div>
I'm not seeing this :(
Can you check this out again glob?  I'm not seeing it.
Flags: needinfo?(glob)
(Reporter)

Comment 3

2 years ago
yes, i still see this.
Flags: needinfo?(glob)
You need to log in before you can comment on or make changes to this bug.