1289033 - add mozilla::UnderlyingType

Status: RESOLVED WONTFIX

(Core :: MFBT, defect)

Description

[Cameron McCormack (:heycam)]

Our set of supported compilers now all have an __underlying_type that we can use to implement a version of std::underlying_type.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1289033 - Add mozilla::UnderlyingType.

Review commit: https://reviewboard.mozilla.org/r/66770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66770/

Comment 2

[James Cheng[:JamesCheng]]

Does it mean that we can invoke std::underlying_type directly?

Is there any policy that we cannot use std directly but need a wrapper to wrap it?

Thanks.

Comment 3

[Cameron McCormack (:heycam)]

Oh, right, maybe https://groups.google.com/forum/#!searchin/mozilla.dev.platform/standard$20library$20support$20enabled%7Csort:relevance/mozilla.dev.platform/v_T59V5QRss/Ti6Shz_mOwAJ means that this is not needed at all.

Comment 4

[Jeff Walden [:Waldo]]

Yeah, I don't think it is.  TypeTraits.h can die a slow or fast death now -- but it definitely seems we shouldn't ever add to it now, unless I'm missing something.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8774240 [details]
Bug 1289033 - Add mozilla::UnderlyingType.

https://reviewboard.mozilla.org/r/66770/#review63586

Yeah, std::underlying_type should work everywhere.  Can you try that out and re-r? this patch if that's not the case?

Comment 6

[Cameron McCormack (:heycam)]

std::underyling_type worked fine on try, so I will use that.  Thanks!