1289066 - [Regression] Latest master does not offer to save Facebook logins on iPads

Status: RESOLVED WORKSFORME

(Firefox for iOS :: Login Management, defect, P3)

Description

[Catalin Suciu [:csuciu]]

master fa14e51
iPad Air 2, iPad Mini (9.3.2)

1. Visit www.facebook.com 
2. Provide a username and password and press Login

Expected: A prompt offering to save the login information should be displayed

Actual: The prompt is not displayed

Note: This issue is not reproducible on phones

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Works on Release Candidate 5.0

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Is this Facebook specific? Or does this also fail for other login forms?

Comment 3

[Catalin Suciu [:csuciu]]

I've investigated this issue a bit more and, when I open Facebook by tapping on the default top site tile, I'm getting the phone version of the site. In this case when I try to login, the prompt is not displayed.

If I open Facebook via URL bar, then I get the tablet/desktop version of the site, and in this case the 'save login' prompt is displayed.

Comment 4

[Aaron Train [:aaronmt]]

I was also thinking if there's a UA discrepancy. 

In any case, the tablet tile default we ship should match user-entry, if not, that's really silly. There should be no better served site. The tile URL we ship should match the equivalent of the user-entered site.

Comment 6

[Maurya Talisetti]

Works on version 8.0(1) on iPad Air 2, iOS 10.2 (both phone and desktop versions of the site)

So, is this still an issue?

Comment 7

[Catalin Suciu [:csuciu]]

Yes, I can still reproduce in latest master. Please note that it only happens when opening facebook from top sites without previously requesting for facebook desktop/mobile page.

Best way to reproduce is to install a fresh build, tap on the facebook top site, then login with a valid account. The prompt to save the login will not show up. 

Also it can be noticed that the facebook page offered when opening from top sites is different that the ones offered when opening via URL bar or when requesting for desktop/mobile sites (in this cases the prompt to save the login is correctly displayed).

Comment 8

[Stephan Leroux [:sleroux]]

Just to confirm, is latest master you tested 7d9cd673b733ea7d39f5f408e38893ccc87c1be7? Asking since the patch I reverted might have caused this regression.

Comment 9

[Catalin Suciu [:csuciu]]

Actually, it was a master older than the one mentioned by you.

Re-tested on master 7f52d8fb533 and observed that the behavior has changed.
When Facebook is accessed from Top Sites or URL bar, the save password prompt is displayed.
On the desktop site (RDS) the prompt is not displayed.

Comment 10

[Maurya Talisetti]

Catalin, for the same master (7f52d8fb533), I noticed the opposite behavior.
When facebook.com is accessed, the prompt is displayed.
But, when m.facebook.com is accessed (from Top Sites or URL bar), the prompt is not displayed.

As an aside, the RDS option seems to be broken. When the desktop site is requested, it gives the mobile site and vice-versa.