Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown

RESOLVED FIXED in Firefox 50

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: aryx, Assigned: aryx)

Tracking

47 Branch
Firefox 50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

Nightly and Aurora 20160724 on Windows 8.1

If the user opens the devtools' network monitor and no requests are shown (use the Trash/Clear button if necessary), moving the mouse over the button in the second sentence which explains how to use the network monitor doesn't show the tooltip added in bug 1242715.
Comment on attachment 8774295 [details]
Bug 1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown.

https://reviewboard.mozilla.org/r/66816/#review63612

Please fix the commit message, it seems to be duplicated with different reviewers each time.

::: devtools/client/netmonitor/netmonitor.xul:296
(Diff revision 1)
>              <hbox id="notice-reload-message" align="center">
>                <label value="&netmonitorUI.reloadNotice1;"/>
>                <button id="requests-menu-reload-notice-button"
>                        class="devtools-toolbarbutton"
>                        standalone="true"
>                        label="&netmonitorUI.reloadNotice2;"/>

It seems this button has the same problem?
Attachment #8774295 - Flags: review?(jryans) → review+
https://reviewboard.mozilla.org/r/66816/#review63612

> It seems this button has the same problem?

No, this button uses the text as label (it contains no icon) while the button already changed has an icon and hides its text: https://dxr.mozilla.org/mozilla-central/rev/db3ed1fdbbeaf5ab1e8fe454780146e7499be3db/devtools/client/themes/netmonitor.css#61-77
Comment on attachment 8774295 [details]
Bug 1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66816/diff/1-2/
Comment on attachment 8774295 [details]
Bug 1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66816/diff/2-3/
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/ddeb0295df69
Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown. r=jryans
https://hg.mozilla.org/mozilla-central/rev/ddeb0295df69
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
I have reproduced this bug with Firefox Nightly 50.0a1 (Build ID:20160725030248) on 
Windows 8.1, 64-bit.

Verified as fixed with Firefox Nightly 50.0a1 (Build ID: 20160729030203)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
QA Whiteboard: [bugday-20160727]
Verified as FIXED on Firefox Aurora 50.0a2 (2016-09-09) on Linux Mint 18 64-bit.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.