1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Nightly and Aurora 20160724 on Windows 8.1

If the user opens the devtools' network monitor and no requests are shown (use the Trash/Clear button if necessary), moving the mouse over the button in the second sentence which explains how to use the network monitor doesn't show the tooltip added in bug 1242715.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown.

Bug 1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown. r?pbro

Review commit: https://reviewboard.mozilla.org/r/66816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66816/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8774295 [details]
Bug 1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown.

https://reviewboard.mozilla.org/r/66816/#review63612

Please fix the commit message, it seems to be duplicated with different reviewers each time.

::: devtools/client/netmonitor/netmonitor.xul:296
(Diff revision 1)
>              <hbox id="notice-reload-message" align="center">
>                <label value="&netmonitorUI.reloadNotice1;"/>
>                <button id="requests-menu-reload-notice-button"
>                        class="devtools-toolbarbutton"
>                        standalone="true"
>                        label="&netmonitorUI.reloadNotice2;"/>

It seems this button has the same problem?

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://reviewboard.mozilla.org/r/66816/#review63612

> It seems this button has the same problem?

No, this button uses the text as label (it contains no icon) while the button already changed has an icon and hides its text: https://dxr.mozilla.org/mozilla-central/rev/db3ed1fdbbeaf5ab1e8fe454780146e7499be3db/devtools/client/themes/netmonitor.css#61-77

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8774295 [details]
Bug 1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66816/diff/1-2/

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8774295 [details]
Bug 1289067 - Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66816/diff/2-3/

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://reviewboard.mozilla.org/r/66816/#review63612

Fixed in updated push.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddeb0295df69
Tooltip for 'Analyze' button (shown if netmonitor view empty) not shown. r=jryans

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ddeb0295df69

Comment 9

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 50.0a1 (Build ID:20160725030248) on 
Windows 8.1, 64-bit.

Verified as fixed with Firefox Nightly 50.0a1 (Build ID: 20160729030203)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

Comment 10

[Subhrajyoti Sen]

Verified as FIXED on Firefox Aurora 50.0a2 (2016-09-09) on Linux Mint 18 64-bit.