1289110 - Handle delayed delivery for presence stanzas

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[Abdelrahman Ahmed [:abdelrahman]]

XEP-0203: Delayed Delivery

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: v1 - delayed delivery for presence

Comment 2

[aleth [:aleth]]

Comment on attachment 8774302 [details] [diff] [review]
v1 - delayed delivery for presence

Review of attachment 8774302 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/xmpp/xmpp.jsm
@@ +63,5 @@
> +  let date = getDelay(aStanza);
> +  if (date)
> +    idleSince = date.getTime();
> +  else
> +    idleSince = 0;

You can keep this case as the default, in the let clause.

@@ +87,5 @@
>  };
>  
> +// Returns a Date object for the delay value (stamp) in aStanza if it exists,
> +// otherwise returns undefined.
> +function getDelay(aStanza) {

_getDelay as this is a helper function.

@@ +95,5 @@
> +  if (delay && delay.uri == Stanza.NS.delay) {
> +    if (delay.attributes["stamp"])
> +      date = new Date(delay.attributes["stamp"]);
> +  }
> +  if ((date && isNaN(date)) || !date)

I don't understand this check.
Either date is undefined, or it's an object. If it's a Date object, when is its conversion to Number not a number? Don't you want to somehow check date is a valid date?

Comment 3

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: v2 - delayed delivery for presence

(In reply to aleth [:aleth] from comment #2)
> I don't understand this check.
> Either date is undefined, or it's an object. If it's a Date object, when is
> its conversion to Number not a number? Don't you want to somehow check date
> is a valid date?

I think this fixed in this patch by using |getTime| in the isNaN check and removing |!date| check.

Comment 4

[Abdelrahman Ahmed [:abdelrahman]]

https://hg.mozilla.org/comm-central/rev/2a04b47cf89a