1289136 - Fifth argument to XPCConvert::NativeInterface2JSObject() is always null

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

I have eliminated the argument and constant propagated the null to remove a little bit of code.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Fifth argument to XPCConvert::NativeInterface2JSObject() is always null.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9008017e28f2

Comment 2

[Andrew McCreight [:mccr8]]

This blocks bug 1288870, because it isn't entirely clear to me how this return argument should be handled in a refcounted world. With this patch, I don't need to worry about it, because it is unused functionality.

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8774374 [details] [diff] [review]
Fifth argument to XPCConvert::NativeInterface2JSObject() is always null.

Bug 1289064 means this has to be changed a bit (to be even simpler!).

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Fifth argument to XPCConvert::NativeInterface2JSObject() is always null.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b807e09863ff
Fifth argument to XPCConvert::NativeInterface2JSObject() is always null. r=gabor

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b807e09863ff