Closed Bug 1289136 Opened 3 years ago Closed 3 years ago

Fifth argument to XPCConvert::NativeInterface2JSObject() is always null

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file, 1 obsolete file)

I have eliminated the argument and constant propagated the null to remove a little bit of code.
This blocks bug 1288870, because it isn't entirely clear to me how this return argument should be handled in a refcounted world. With this patch, I don't need to worry about it, because it is unused functionality.
Comment on attachment 8774374 [details] [diff] [review]
Fifth argument to XPCConvert::NativeInterface2JSObject() is always null.

Bug 1289064 means this has to be changed a bit (to be even simpler!).
Attachment #8774374 - Attachment is obsolete: true
Attachment #8774374 - Flags: review?(gkrizsanits)
Attachment #8775201 - Flags: review?(gkrizsanits) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b807e09863ff
Fifth argument to XPCConvert::NativeInterface2JSObject() is always null. r=gabor
https://hg.mozilla.org/mozilla-central/rev/b807e09863ff
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.