remove eSurvivingInUpdate flag from Accessible class

RESOLVED FIXED in Firefox 57

Status

()

P5
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: surkov, Assigned: njfox)

Tracking

({good-first-bug})

unspecified
mozilla57
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Comment hidden (mozreview-request)
(Reporter)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8843038 [details]
Bug 1289157 - Removed eSurvivingInUpdate flag and corresponding function

https://reviewboard.mozilla.org/r/116798/#review118430

::: accessible/generic/Accessible.h:1033
(Diff revision 1)
> -    eSurvivingInUpdate = 1 << 8, // parent drops children to recollect them
>      eRelocated = 1 << 9, // accessible was moved in tree
>      eNoXBLKids = 1 << 10, // accessible don't allows XBL children
>      eNoKidsFromDOM = 1 << 11, // accessible doesn't allow children from DOM
>      eHasTextKids = 1 << 12, // accessible have a text leaf in children
>  

could you bump indexes down please and adjust kStateFlagsBits value correspondingly too
Comment hidden (mozreview-request)
(Reporter)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8843038 [details]
Bug 1289157 - Removed eSurvivingInUpdate flag and corresponding function

https://reviewboard.mozilla.org/r/116798/#review118764

thanks, that should work
Attachment #8843038 - Flags: review?(surkov.alexander) → review+
(Reporter)

Updated

2 years ago
Assignee: nobody → nick
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Autoland can't push this until the patch has r+ from someone with Level 3 access in MozReview.
Flags: needinfo?(surkov.alexander)
Keywords: checkin-needed
(Reporter)

Comment 6

2 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> Autoland can't push this until the patch has r+ from someone with Level 3
> access in MozReview.

presumably my access level is not 3 or did I set r+ incorrectly somehow? what ways to resolve the issue?

btw, what level 3 access in mozreview stands for and does autoland runs a try server build to make sure we are in good shape at least the patch compiles?
Flags: needinfo?(surkov.alexander)
Level 3 commit access. Though in your case, I'm betting it's because your hg email address differs from your BMO one.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#manually-associating-your-ldap-account-with-mozreview
(Reporter)

Comment 8

2 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> Level 3 commit access. Though in your case, I'm betting it's because your hg
> email address differs from your BMO one.

It seems same, hg's and this one are both <surkov.alexander@gmail.com>

> http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/
> install.html#manually-associating-your-ldap-account-with-mozreview

I run ssh reviewboard-hg.mozilla.org mozreview-ldap-associate, created a new mozreview API keys (the existing one is 'hidden' in bugzilla prefs). How can check if it worked out?
(Reporter)

Updated

a year ago
Priority: -- → P5
(Reporter)

Comment 9

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7197abf8c984aa4c582e3ad7c9793a4bd4ecbe44
Bug 1289157 - remove eSurvivingInUpdate flag from Accessible class, r=surkov

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7197abf8c984
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.