Closed Bug 1289157 Opened 6 years ago Closed 5 years ago
Surviving In Update flag from Accessible class
59 bytes, text/x-review-board-request
no longer needed, just remove it, see   https://dxr.mozilla.org/mozilla-central/rev/4c05938a64a7fde3ac2d7f4493aee1c5f2ad8a0a/accessible/generic/Accessible.h#1012
Comment on attachment 8843038 [details] Bug 1289157 - Removed eSurvivingInUpdate flag and corresponding function https://reviewboard.mozilla.org/r/116798/#review118430 ::: accessible/generic/Accessible.h:1033 (Diff revision 1) > - eSurvivingInUpdate = 1 << 8, // parent drops children to recollect them > eRelocated = 1 << 9, // accessible was moved in tree > eNoXBLKids = 1 << 10, // accessible don't allows XBL children > eNoKidsFromDOM = 1 << 11, // accessible doesn't allow children from DOM > eHasTextKids = 1 << 12, // accessible have a text leaf in children > could you bump indexes down please and adjust kStateFlagsBits value correspondingly too
Comment on attachment 8843038 [details] Bug 1289157 - Removed eSurvivingInUpdate flag and corresponding function https://reviewboard.mozilla.org/r/116798/#review118764 thanks, that should work
Attachment #8843038 - Flags: review?(surkov.alexander) → review+
Autoland can't push this until the patch has r+ from someone with Level 3 access in MozReview.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5) > Autoland can't push this until the patch has r+ from someone with Level 3 > access in MozReview. presumably my access level is not 3 or did I set r+ incorrectly somehow? what ways to resolve the issue? btw, what level 3 access in mozreview stands for and does autoland runs a try server build to make sure we are in good shape at least the patch compiles?
Level 3 commit access. Though in your case, I'm betting it's because your hg email address differs from your BMO one. http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#manually-associating-your-ldap-account-with-mozreview
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7) > Level 3 commit access. Though in your case, I'm betting it's because your hg > email address differs from your BMO one. It seems same, hg's and this one are both <firstname.lastname@example.org> > http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/ > install.html#manually-associating-your-ldap-account-with-mozreview I run ssh reviewboard-hg.mozilla.org mozreview-ldap-associate, created a new mozreview API keys (the existing one is 'hidden' in bugzilla prefs). How can check if it worked out?
https://hg.mozilla.org/integration/mozilla-inbound/rev/7197abf8c984aa4c582e3ad7c9793a4bd4ecbe44 Bug 1289157 - remove eSurvivingInUpdate flag from Accessible class, r=surkov
You need to log in before you can comment on or make changes to this bug.